Skip to content

feat: Support seek subscription in AdminClient #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 10, 2021
Merged

feat: Support seek subscription in AdminClient #176

merged 10 commits into from
Aug 10, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jul 2, 2021

Seek subscription performs an out-of-band seek for a subscription to a specified target, which may be a backlog location, publish timestamp or event timestamp.
@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 2, 2021
@tmdiep tmdiep requested review from a team as code owners July 2, 2021 04:35
@snippet-bot
Copy link

snippet-bot bot commented Jul 2, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Jul 2, 2021
@tmdiep
Copy link
Contributor Author

tmdiep commented Jul 2, 2021

Note: this feature is pre-release. The "do not merge" label will be removed once publicly available.
@tmdiep tmdiep force-pushed the seek_subscription branch from 8587b10 to def076e Compare July 2, 2021 05:28
@tmdiep tmdiep force-pushed the seek_subscription branch from dfead22 to fe18203 Compare July 7, 2021 05:15
@tmdiep tmdiep requested a review from dpcollins-google July 29, 2021 00:29
anguillanneuf
anguillanneuf reviewed Jul 29, 2021
View reviewed changes
dpcollins-google
dpcollins-google reviewed Aug 4, 2021
View reviewed changes
dpcollins-google
dpcollins-google approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming fixes are made
@tmdiep tmdiep added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 8, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 8, 2021
@tmdiep tmdiep merged commit fc648ae into googleapis:master Aug 10, 2021
@tmdiep tmdiep deleted the seek_subscription branch August 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

4 participants

@tmdiep @anguillanneuf @dpcollins-google @yoshi-kokoro