Skip to content

fix: improve cell magic error message on missing query #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2020
Merged

fix: improve cell magic error message on missing query #58

merged 5 commits into from
Mar 26, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Mar 10, 2020

Fixes #57.

This PR fixes the Jupyter cell magic error message if query is missing. The steps to reproduce/verify the fix are in the issue description.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from shollyman March 10, 2020 13:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
shollyman
shollyman approved these changes Mar 16, 2020
View reviewed changes
@plamut plamut mentioned this pull request Mar 17, 2020
Closed
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@plamut plamut merged commit 6182cf4 into googleapis:master Mar 26, 2020
@plamut plamut deleted the iss-57 branch March 26, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants

@plamut @shollyman @googlebot @yoshi-kokoro