This repository was archived by the owner on Sep 12, 2025. It is now read-only.
fix: handle consuming streams with no data #29
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #27.
This PR fixes the issue with consuming streams with no data. If an empty stream is encountered, the
to_dataframe()/to_arrow()method returns an empty DataFrame / arrow Table.The schema of the empty result is preserved (on a best-effort basis) and is consistent regardless of the chosen session data format.
How to reproduce
Run a query and fetch its results in an AVRO/ARROW session with multiple requested streams. The query results should be large enough so that the backend indeed decides to create multiple streams.
Additionally, the session should have a very tight
row_restrictionfilter applied so that only a few rows actually get streamed to the client. If "lucky", at least one of the streams will contain no data and will result in an error when reading from it.Things to discuss
v1beta1client? I presume not?PR checklist