fix: add parameters_value in PipelineJob for schema > 2.0.0 #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: aiplatform 
google-cla bot added the cla: yes 
ji-yaqi force-pushed the protobuf_val branch 2 times, most recently from bcad4c5 to 6c689d2 Compare 
ji-yaqi added the do not merge 
Contributor Author
| Hold the PR for now, for testing with KFP 2.0 |
chensun approved these changes Nov 15, 2021
| def _get_vertex_value( | ||
| self, name: str, value: Union[int, float, str, bool, list, dict] | ||
| ) -> Dict[str, Any]: | ||
| ) -> Union[Dict[str, Any], int, float, str, bool, list, dict]: |
Member
There was a problem hiding this comment.
nit: maybe remove Dict[str, Any] since it's covered by dict?
ji-yaqi force-pushed the protobuf_val branch from b6643a2 to df9c883 Compare ji-yaqi removed the do not merge Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.