fix: making the uploader depend on tensorflow-proper #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: aiplatform 
yfang1 changed the title yfang1 changed the title 
sasha-gitg approved these changes Jun 24, 2021
dizcology approved these changes Jun 25, 2021
ji-yaqi pushed a commit to ji-yaqi/python-aiplatform that referenced this pull request Jun 30, 2021
Co-authored-by: Yicheng Fang <yichengfang@google.com>
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 5, 2021
…#593) Reapplying #499 to remove the extra dependencies introduced by merge conflict in f6f9a97#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7L32-R36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes b/191305567.
Vertex notebooks, and (I suppose) the majority of users have "tensorflow" installed, instead of "tensorflow-cpu", which doesn't play nice with "tensorflow" and forces to pin on weird specific dependency versions.
Tried on notebooks with TF 2.3 and 2.5, as well as brand-new conda envs. All seemed working fine.