feat: column specs for tabular transformation #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: aiplatform 
google-cla bot added the cla: yes 
ivanmkc reviewed Jun 8, 2021
sirtorry commented Jun 8, 2021
sirtorry commented Jun 8, 2021
sirtorry changed the title 
sasha-gitg requested changes Jun 21, 2021
sirtorry requested review from ivanmkc and sasha-gitg and removed request for vinnysenthil sasha-gitg requested changes Jul 13, 2021
ivanmkc reviewed Jul 13, 2021
ivanmkc reviewed Jul 13, 2021
ivanmkc reviewed Jul 13, 2021
ivanmkc reviewed Jul 13, 2021
ivanmkc reviewed Jul 13, 2021
sasha-gitg approved these changes Jul 15, 2021
Member
sasha-gitg left a comment
sasha-gitg left a comment There was a problem hiding this comment.
Mainly LGTM. One more comment it seems I didn't include in the last review. Thanks!
ivanmkc approved these changes Jul 15, 2021
Contributor
ivanmkc left a comment
ivanmkc left a comment There was a problem hiding this comment.
LGTM after Sasha's suggestion
Contributor
| What about the deprecation warning for column_transformations? |
sirtorry added the automerge 
gcf-merge-on-green bot removed the automerge Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.