Skip to content

Conversation

geraint0923
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Jun 5, 2021
self, location_override: Optional[str] = None
self, location_override: Optional[str] = None, prediction_client: bool = False
) -> client_options.ClientOptions:
"""Creates GAPIC client_options using location and type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a docstring update.

@geraint0923 geraint0923 force-pushed the override_prediction branch from b48c0c3 to d265924 Compare June 10, 2021 17:08
@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c2cf612 into googleapis:master Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2021
@geraint0923 geraint0923 deleted the override_prediction branch June 10, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

2 participants