fix: npe in createFrom #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: storage 
Codecov Report
@@ Coverage Diff @@ ## master #746 +/- ## ============================================ + Coverage 64.60% 64.61% +0.01% Complexity 625 625 ============================================ Files 32 32 Lines 5311 5313 +2 Branches 520 520 ============================================ + Hits 3431 3433 +2 Misses 1718 1718 Partials 162 162
Continue to review full report at Codecov.
|
BenWhitehead approved these changes Mar 8, 2021
This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
createFrom expects object metadata to be available once uploaded. If response metadata is not available a get object metadata request is made with a null Options parameter which causes an NPE. I tested the change by running IT with multiple uploads to validate failure no longer occurs.
Fixes #745 ☕️