- Notifications
You must be signed in to change notification settings - Fork 86
Closed
Labels
api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Following #647, we no longer sometimes see:
java.lang.NullPointerException: null at com.google.cloud.storage.spi.v1.HttpStorageRpc.getCurrentUploadOffset(HttpStorageRpc.java:783) at com.google.cloud.storage.BlobWriteChannel$1.run(BlobWriteChannel.java:125) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105) at com.google.cloud.RetryHelper.run(RetryHelper.java:76) at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50) at com.google.cloud.storage.BlobWriteChannel.flushBuffer(BlobWriteChannel.java:70) at com.google.cloud.BaseWriteChannel.close(BaseWriteChannel.java:151) at com.google.cloud.storage.StorageImpl.createFrom(StorageImpl.java:265) ...snip... This appeared in 1.113.4 but no longer appears in 1.113.6. Thanks for the fix.
Instead (in 1.113.6) we now sometimes see:
com.google.cloud.storage.StorageException: Resumable upload is already complete. at com.google.cloud.storage.spi.v1.HttpStorageRpc.getCurrentUploadOffset(HttpStorageRpc.java:769) at com.google.cloud.storage.BlobWriteChannel$1.run(BlobWriteChannel.java:125) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105) at com.google.cloud.RetryHelper.run(RetryHelper.java:76) at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50) at com.google.cloud.storage.BlobWriteChannel.flushBuffer(BlobWriteChannel.java:70) at com.google.cloud.BaseWriteChannel.close(BaseWriteChannel.java:151) at com.google.cloud.storage.StorageImpl.createFrom(StorageImpl.java:265) ...snip... What do you think? More tweaks to #604 required?
Thanks for your time.
Metadata
Metadata
Assignees
Labels
api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.