Skip to content

fix: throw io exception instead of storage exception #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2020
Merged

fix: throw io exception instead of storage exception #229

merged 2 commits into from
Apr 7, 2020

Conversation

dmitry-fa
Copy link
Contributor

Fixes #219
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #229 into master will decrease coverage by 0.17%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #229 +/- ## ============================================ - Coverage 63.67% 63.50% -0.18%  + Complexity 548 540 -8  ============================================ Files 31 30 -1 Lines 4782 4762 -20 Branches 428 427 -1 ============================================ - Hits 3045 3024 -21  - Misses 1577 1578 +1  Partials 160 160
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/storage/BlobReadChannel.java 85.71% <50.00%> (ø) 16.00 <0.00> (ø)
...e/src/main/java/com/google/cloud/storage/Blob.java 81.97% <91.66%> (-0.28%) 29.00 <0.00> (ø)
...va/com/google/cloud/storage/StorageOperations.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5599f29...a7cac71. Read the comment docs.
@dmitry-fa dmitry-fa requested a review from frankyn April 6, 2020 16:06
@frankyn frankyn requested a review from JesseLovelace April 6, 2020 16:29
@dmitry-fa dmitry-fa requested a review from elharo April 7, 2020 09:44
@frankyn frankyn requested review from elharo and removed request for JesseLovelace April 7, 2020 16:58
@frankyn
Copy link
Contributor

frankyn commented Apr 7, 2020

@elharo could I get your review on this PR.

I want another perspective.
frankyn
frankyn suggested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing. Thanks for putiing this together @dmitry-fa
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java
if (result.y().length > 0 && lastEtag != null && !Objects.equals(result.x(), lastEtag)) {
StringBuilder messageBuilder = new StringBuilder();
messageBuilder.append("Blob ").append(blob).append(" was updated while reading");
throw new StorageException(0, messageBuilder.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this will no longer be retried. Well it shouldn't be so maybe that's not an issue.
frankyn
frankyn approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt both, follow-up.

Let's move forward. LGTM.
@frankyn frankyn merged commit 4d42a4e into googleapis:master Apr 7, 2020
@dmitry-fa dmitry-fa deleted the StorageIOException branch June 26, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants

@dmitry-fa @frankyn @elharo @googlebot