fix: session retry could cause infinite wait #616
Conversation
A "Session not found" when using an AsyncTransactionManager could cause an infinite wait for an ApiFuture that would never be done. Fixes #605
google-cla bot added the cla: yes 
product-auto-label bot added the api: spanner 
| @Override | ||
| public void onFailure(Throwable t) { | ||
| mgr.onError(t); | ||
| statementResult.setException(t); |
There was a problem hiding this comment.
This missing statement was what could cause the infinite wait. The result of this specific statement would never be done if the previous statement (input) would fail.
| | ||
| @Override | ||
| public TransactionContextFuture resetForRetryAsync() { | ||
| if (txn == null || (!txn.isAborted() && txnState != TransactionState.ABORTED)) { |
There was a problem hiding this comment.
This check is no longer needed here as it is checked in the SessionPoolAsyncTransactionManager.
| txnState == TransactionState.STARTED || txnState == TransactionState.ABORTED, | ||
| "commit can only be invoked if the transaction is in progress. Current state: " | ||
| + txnState); | ||
| if (txnState == TransactionState.ABORTED) { |
There was a problem hiding this comment.
This makes sure that the AsyncTransactionManager will return an ApiFuture with exception Aborted if the transaction has already been aborted by an asynchronous statement that has not yet been checked by the application, e.g. (simplified):
txn.updateAsync(...); // This aborts the transaction, but the status of the returned ApiFuture is not checked by the application. ... txn.commitAsync();
Codecov Report
@@ Coverage Diff @@ ## master #616 +/- ## ============================================ + Coverage 83.79% 84.04% +0.24% - Complexity 2500 2502 +2 ============================================ Files 141 141 Lines 13770 13810 +40 Branches 1278 1318 +40 ============================================ + Hits 11538 11606 +68 - Misses 1655 1657 +2 + Partials 577 547 -30 Continue to review full report at Codecov.
|
…ts (googleapis#616) Removes the category from the base class for all integration tests so they are not excluded from multiple builds, as the result is that both the category of the base class as well as the concrete class are applied.
2 participants
A "Session not found" when using an AsyncTransactionManager could cause an infinite wait for an
ApiFuturethat would never be done.Fixes #605