fix: improve numeric range checks #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #424 +/- ## ============================================ + Coverage 82.16% 82.18% +0.01% - Complexity 2455 2458 +3 ============================================ Files 136 136 Lines 13589 13599 +10 Branches 1307 1310 +3 ============================================ + Hits 11166 11176 +10 Misses 1895 1895 Partials 528 528
Continue to review full report at Codecov.
|
skuruppu reviewed Sep 15, 2020
product-auto-label bot added the api: spanner 
thiagotnunes approved these changes Sep 18, 2020
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
) Source-Author: Jeff Ching <chingor@google.com> Source-Date: Fri Apr 9 09:18:54 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5b0e1592dd7d70b485e157ea4b3eb1704ecbd015 Source-Link: googleapis/synthtool@5b0e159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds additional checks on
NUMERICvalues before sending them to Cloud Spanner in order to return sensible error messages as soon as possible, and adds documentation on how to handleNUMERICvalues with trailing zeros in the fractional part.