feat: add lazy initializer #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #423 +/- ## ========================================= Coverage 82.16% 82.17% - Complexity 2455 2460 +5 ========================================= Files 136 138 +2 Lines 13589 13605 +16 Branches 1307 1309 +2 ========================================= + Hits 11166 11180 +14 - Misses 1895 1896 +1 - Partials 528 529 +1
Continue to review full report at Codecov.
|
product-auto-label bot added the api: spanner 
| * Generic {@link AbstractLazyInitializer} for any heavy-weight object that might throw an exception | ||
| * during initialization. The underlying object is initialized at most once. | ||
| */ | ||
| public abstract class AbstractLazyInitializer<T> { |
Contributor
There was a problem hiding this comment.
Could we use composition instead of inheritance (pass in the initialiser function instead of overriding it)?
Collaborator Author
There was a problem hiding this comment.
That would be possible, but as we have to support Java 7, that would mean that we would have to use com.google.cloud.base.Function in the public interface. I think that it is more idiomatic to use inheritance than composition for Java 7 (once we drop Java 7 support, I would agree that using composition would be a lot nicer in this case).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#2682
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a
LazyInitializerforSpannerinstances that can be used in environments where it is desirable to initialize one instance once, and reuse this for multiple purposes, such as for example Google Cloud Functions.This change would allow us to simplify the Google Cloud Functions Java sample.
Towards GoogleCloudPlatform/java-docs-samples#2862.