Skip to content

docs: fix javadoc for Date type #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiagotnunes merged 1 commit into from
Apr 26, 2021
Merged

docs: fix javadoc for Date type #1102

thiagotnunes merged 1 commit into from
Apr 26, 2021

Conversation

@olavloite
Copy link
Collaborator

@olavloite olavloite commented Apr 26, 2021

Fix wrong Java docs for Date type.

Source: https://cloud.google.com/spanner/docs/data-definition-language#date
@olavloite olavloite requested a review from thiagotnunes April 26, 2021 12:12
@olavloite olavloite requested a review from a team as a code owner April 26, 2021 12:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021 •
edited
Loading

Codecov Report

Merging #1102 (d5943fe) into master (3fd3902) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1102 +/- ## ============================================ + Coverage 84.91% 84.92% +0.01%  Complexity 2725 2725 ============================================ Files 156 156 Lines 14410 14410 Branches 1379 1379 ============================================ + Hits 12236 12238 +2  + Misses 1605 1604 -1  + Partials 569 568 -1
Impacted Files Coverage Δ Complexity Δ
...r/src/main/java/com/google/cloud/spanner/Type.java 93.20% <ø> (ø) 59.00 <0.00> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.21% <0.00%> (+0.19%) 75.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd3902...d5943fe. Read the comment docs.
@thiagotnunes thiagotnunes merged commit ce095f7 into master Apr 26, 2021
@thiagotnunes thiagotnunes deleted the date-docs branch April 26, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

2 participants

@olavloite @thiagotnunes