fix: do not keep references to invalidated clients #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SpannerImpl would keep a reference to all database clients that had been created and then invalidated because the database was deleted or did not exists in the first place. If the getDatabaseClient(String) method would be called multiple times for the same invalid database, the memory usage of the application would continue to increase. Fixes #1089
product-auto-label bot added the api: spanner 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #1093 +/- ## ============================================ - Coverage 85.15% 85.13% -0.03% + Complexity 2720 2717 -3 ============================================ Files 155 155 Lines 14351 14349 -2 Branches 1358 1358 ============================================ - Hits 12221 12216 -5 - Misses 1562 1566 +4 + Partials 568 567 -1
Continue to review full report at Codecov.
|
thiagotnunes approved these changes Apr 25, 2021
thiagotnunes added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
Contributor
| Thanks for the fix! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SpannerImpl would keep a reference to all database clients that had been created and then invalidated because the database was deleted or did not exists in the first place. If the getDatabaseClient(String) method would be called multiple times for the same invalid database, the memory usage of the application would continue to increase.
Fixes #1089