fix: local connection checker ignores exceptions #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The local connection checker should only check for unavailable exceptions when warning the user about the spanner emulator configuration. It should ignore all other kinds of errors.
product-auto-label bot added the api: spanner 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #1036 +/- ## ============================================ + Coverage 85.20% 85.21% +0.01% - Complexity 2642 2644 +2 ============================================ Files 155 155 Lines 14413 14412 -1 Branches 1348 1348 ============================================ + Hits 12280 12281 +1 + Misses 1564 1562 -2 Partials 569 569
Continue to review full report at Codecov.
|
olavloite approved these changes Apr 6, 2021
| @Test | ||
| public void testNoRunningEmulator() { | ||
| final String uri = | ||
| "cloudspanner://localhost:42424/projects/proj/instances/inst/databases/db?usePlainText=true"; |
Collaborator
There was a problem hiding this comment.
nit: It might be safer to use server.getPort() - 1 instead of 42424, as there is a 1/65000 chance that the port assigned to the mock server in this test happens to be 42424.
Contributor Author
There was a problem hiding this comment.
Good point, updated it.
thiagotnunes added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run thiagotnunes removed the cla: yes google-cla bot added the cla: yes rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.13](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.7.12...v2.7.13) (2022-10-31) ### Dependencies * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.32.0 ([googleapis#1033](https://togithub.com/googleapis/java-spanner-jdbc/issues/1033)) ([bbbd2c6](https://togithub.com/googleapis/java-spanner-jdbc/commit/bbbd2c65d75a5805965fa7f9b9dc820e62f34ad3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The local connection checker should only check for unavailable exceptions when warning the user about the spanner emulator configuration. It should ignore all other kinds of errors.