Skip to content

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Mar 30, 2021

Uses plain text, instead of ssl when testing for local connections. This fixes connection checks when using the MockSpannerServiceImpl and it works with the emulator as well.

Without this fix we would get a transport error when testing the getConnection when using the MockSpannerServiceImpl, since the client would expect TLS, while the server would be serving plainText.

Uses plain text, instead of ssl when testing for local connections.
@thiagotnunes thiagotnunes requested a review from a team as a code owner March 30, 2021 05:14
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@thiagotnunes thiagotnunes requested a review from olavloite March 30, 2021 05:14
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1020 (f43896f) into master (25890de) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1020 +/- ## ============================================ - Coverage 85.12% 85.10% -0.02%  + Complexity 2627 2623 -4  ============================================ Files 155 155 Lines 14369 14374 +5 Branches 1340 1340 ============================================ + Hits 12231 12233 +2  - Misses 1571 1573 +2  - Partials 567 568 +1 
Impacted Files Coverage Δ Complexity Δ
...oud/spanner/connection/LocalConnectionChecker.java 82.05% <100.00%> (+8.52%) 6.00 <1.00> (+1.00)
.../google/cloud/spanner/AbstractLazyInitializer.java 92.85% <0.00%> (-7.15%) 4.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.93% <0.00%> (-0.39%) 71.00% <0.00%> (-2.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25890de...f43896f. Read the comment docs.

@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2021
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing that one!

@thiagotnunes thiagotnunes merged commit 1e6e23f into master Mar 30, 2021
@thiagotnunes thiagotnunes deleted the fix-local-connection-checker-plain-text branch March 30, 2021 06:57
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

3 participants