Update cloudshell editor link and runtime directory #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: spanner 
google-cla bot added the cla: yes 
elefeint force-pushed the fix-cloudshell branch from 66d8261 to 018ebca Compare 
Codecov Report
@@ Coverage Diff @@ ## master #1012 +/- ## ========================================= Coverage 85.11% 85.12% - Complexity 2619 2621 +2 ========================================= Files 154 154 Lines 14324 14324 Branches 1334 1334 ========================================= + Hits 12192 12193 +1 + Misses 1569 1567 -2 - Partials 563 564 +1
Continue to review full report at Codecov.
|
thiagotnunes approved these changes Mar 24, 2021
Contributor
thiagotnunes left a comment
thiagotnunes left a comment There was a problem hiding this comment.
Thanks for fixing this!
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will get the correct repo to clone, and instruct the user to switch directories to run commands, but I am not sure the fix is sufficient.
The samples (
SpannerSample.java,QuickstartSample.java,BatchSample.java) use the default project, which seems to be unset when cloud shell opens. Perhaps they should be modified to take project ID as a runtime argument, too?Fixes #1010