fix: add support for WITH clauses #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #42 +/- ## ========================================= Coverage ? 77.83% Complexity ? 1721 ========================================= Files ? 60 Lines ? 5866 Branches ? 825 ========================================= Hits ? 4566 Misses ? 926 Partials ? 374
Continue to review full report at Codecov.
|
hengfengli approved these changes Jan 27, 2020
Contributor
hengfengli left a comment
hengfengli left a comment There was a problem hiding this comment.
LGTM. Good to see this supported by spanner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cloud Spanner now also support
WITHclauses in aSELECTstatement. These clauses were not recognized by the JDBC driver.Fixes #41