Skip to content

fix: Updates for import #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpcollins-google merged 1 commit into from
Jul 9, 2021
Merged

fix: Updates for import #743

dpcollins-google merged 1 commit into from
Jul 9, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jul 9, 2021

  • Makes CloudRegionOrZone.Kind public so that users can check the kind before accessing region() or zone(). Otherwise an exception is thrown when accessing the wrong type.
  • Fixed a few lint errors.
@tmdiep tmdiep requested a review from dpcollins-google July 9, 2021 00:41
@tmdiep tmdiep requested a review from a team as a code owner July 9, 2021 00:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jul 9, 2021
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2021
@dpcollins-google dpcollins-google merged commit 245004e into googleapis:master Jul 9, 2021
@tmdiep tmdiep deleted the updates_for_import branch July 29, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

3 participants

@tmdiep @dpcollins-google @yoshi-kokoro