fix: Fix BufferingPullSubscriber to not seek after sending flow control tokens. #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ol tokens. Seeking after sending tokens will discard any flow control tokens sent to the server. Also, update BufferingPullSubscriber to accept arbitrary initial seek requests.
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #253 +/- ## ============================================ - Coverage 72.74% 72.59% -0.16% Complexity 759 759 ============================================ Files 135 135 Lines 4033 4032 -1 Branches 213 212 -1 ============================================ - Hits 2934 2927 -7 - Misses 975 981 +6 Partials 124 124
Continue to review full report at Codecov.
|
palmere-google approved these changes Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Seeking after sending tokens will discard any flow control tokens sent to the server. Also, update BufferingPullSubscriber to accept arbitrary initial seek requests.