docs: Update samples for v0.3.0 #235
Conversation
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #235 +/- ## ========================================= Coverage 72.94% 72.94% Complexity 751 751 ========================================= Files 135 135 Lines 3977 3977 Branches 208 208 ========================================= Hits 2901 2901 Misses 953 953 Partials 123 123
Continue to review full report at Codecov.
|
product-auto-label bot added the api: pubsublite 
manuelmenzella-google left a comment
manuelmenzella-google left a comment There was a problem hiding this comment.
Tianzi may be interested in these changes.
lesv left a comment
lesv left a comment There was a problem hiding this comment.
LGTM - for java-sample-reviewers
I like the changes to the API, but wonder about using the project Number instead of the more common projectName.
You might wish to check the warnings from CodeCov - as the changes it calls out as not being covered seem like important parts of the sample.
| .setZone(CloudZone.of(CloudRegion.of(cloudRegion), zoneId)) | ||
| .setTopicName(TopicName.of(topicId)) | ||
| TopicPath.newBuilder() | ||
| .setProject(ProjectNumber.of(projectNumber)) |
There was a problem hiding this comment.
don't we use projectName everywhere else in cloud?
3 participants
No description provided.