Skip to content

Commit 69106fe

Browse files
deps: define Beam version as a Maven property in pom (#714)
* deps: bump maven version and remove explicit version override for fmt and dependency plugins which are present in the base configuration * fix: dep scoping * Set version on old snippets to 2.29.0 2.30.0 won't work with the I/O not built with that version. Lower versions will work. Co-authored-by: Tianzi Cai <tianzi@google.com>
1 parent a46ee38 commit 69106fe

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

pubsublite-beam-io/pom.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
<name>Pub/Sub Lite IO</name>
1717
<url>https://github.com/googleapis/java-pubsublite</url>
1818
<description>Beam IO for Google Cloud Pub/Sub Lite</description>
19+
<properties>
20+
<beam.version>2.30.0</beam.version>
21+
</properties>
1922
<dependencies>
2023
<dependency>
2124
<groupId>com.google.cloud</groupId>
@@ -85,12 +88,12 @@
8588
<dependency>
8689
<groupId>org.apache.beam</groupId>
8790
<artifactId>beam-sdks-java-core</artifactId>
88-
<version>2.29.0</version>
91+
<version>${beam.version}</version>
8992
</dependency>
9093
<dependency>
9194
<groupId>org.apache.beam</groupId>
9295
<artifactId>beam-sdks-java-extensions-protobuf</artifactId>
93-
<version>2.29.0</version>
96+
<version>${beam.version}</version>
9497
</dependency>
9598
<dependency>
9699
<groupId>com.google.flogger</groupId>
@@ -124,7 +127,7 @@
124127
<dependency>
125128
<groupId>org.apache.beam</groupId>
126129
<artifactId>beam-runners-direct-java</artifactId>
127-
<version>2.29.0</version>
130+
<version>${beam.version}</version>
128131
<scope>test</scope>
129132
</dependency>
130133
</dependencies>

samples/snapshot/pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
<maven.compiler.target>1.8</maven.compiler.target>
3939
<maven.compiler.source>1.8</maven.compiler.source>
4040
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
41+
<beam.version>2.30.0</beam.version>
4142
</properties>
4243

4344
<dependencies>
@@ -63,7 +64,7 @@
6364
<dependency>
6465
<groupId>org.apache.beam</groupId>
6566
<artifactId>beam-model-pipeline</artifactId>
66-
<version>2.29.0</version>
67+
<version>${beam.version}</version>
6768
</dependency>
6869

6970
<dependency>
@@ -81,7 +82,7 @@
8182
<dependency>
8283
<groupId>org.apache.beam</groupId>
8384
<artifactId>beam-runners-direct-java</artifactId>
84-
<version>2.29.0</version>
85+
<version>${beam.version}</version>
8586
<scope>test</scope>
8687
</dependency>
8788
</dependencies>

samples/snippets/pom.xml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
<maven.compiler.target>1.8</maven.compiler.target>
3939
<maven.compiler.source>1.8</maven.compiler.source>
4040
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
41+
<beam.version>2.29.0</beam.version>
4142
</properties>
4243

4344
<dependencies>
@@ -55,17 +56,17 @@
5556
</dependency>
5657
<!-- [END pubsublite_java_dependencies] -->
5758
<!-- [END pubsublite_install_without_bom] -->
58-
59+
60+
<dependency>
61+
<groupId>org.apache.beam</groupId>
62+
<artifactId>beam-model-pipeline</artifactId>
63+
<version>${beam.version}</version>
64+
</dependency>
5965
<dependency>
6066
<groupId>com.google.cloud</groupId>
6167
<artifactId>pubsublite-beam-io</artifactId>
6268
<version>0.16.1</version>
6369
</dependency>
64-
<dependency>
65-
<groupId>org.apache.beam</groupId>
66-
<artifactId>beam-model-pipeline</artifactId>
67-
<version>2.29.0</version>
68-
</dependency>
6970

7071
<dependency>
7172
<groupId>junit</groupId>
@@ -82,7 +83,7 @@
8283
<dependency>
8384
<groupId>org.apache.beam</groupId>
8485
<artifactId>beam-runners-direct-java</artifactId>
85-
<version>2.29.0</version>
86+
<version>${beam.version}</version>
8687
<scope>test</scope>
8788
</dependency>
8889
</dependencies>

0 commit comments

Comments
 (0)