Skip to content

Commit 6595f63

Browse files
chore: minor test cleanup (#726)
1 parent d9b4595 commit 6595f63

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import com.google.cloud.bigtable.test_helpers.env.EmulatorEnv;
4444
import com.google.cloud.bigtable.test_helpers.env.TestEnvRule;
4545
import com.google.common.collect.Lists;
46-
import com.google.protobuf.Timestamp;
46+
import com.google.protobuf.ByteString;
4747
import io.grpc.StatusRuntimeException;
4848
import java.io.IOException;
4949
import java.util.List;
@@ -119,7 +119,7 @@ public static void createClient()
119119
ApiFuture<Void> future =
120120
dataClient.mutateRowAsync(
121121
RowMutation.create(testTable.getId(), "test-row-" + i)
122-
.setCell("cf1", "", rowBytes.toString()));
122+
.setCell("cf1", ByteString.EMPTY, ByteString.copyFrom(rowBytes)));
123123
futures.add(future);
124124
}
125125
ApiFutures.allAsList(futures).get(3, TimeUnit.MINUTES);
@@ -188,7 +188,7 @@ public void createAndGetBackupTest() throws InterruptedException {
188188
.isEqualTo(expireTime);
189189
assertWithMessage("Got empty start time in GetBackup API")
190190
.that(result.getStartTime())
191-
.isNotEqualTo(Timestamp.getDefaultInstance());
191+
.isNotNull();
192192
assertWithMessage("Got wrong size bytes in GetBackup API")
193193
.that(result.getSizeBytes())
194194
.isEqualTo(0L);

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/BigtableDataSettingsTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@
1919

2020
import com.google.cloud.bigtable.data.v2.stub.EnhancedBigtableStubSettings;
2121
import org.junit.Test;
22+
import org.junit.runner.RunWith;
23+
import org.junit.runners.JUnit4;
2224

25+
@RunWith(JUnit4.class)
2326
public class BigtableDataSettingsTest {
2427

2528
@Test

0 commit comments

Comments
 (0)