Skip to content

feat: add requirePartitionFilter field in HivePartitioningOptions #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

feat: add requirePartitionFilter field in HivePartitioningOptions #803

merged 1 commit into from
Oct 15, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Oct 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #251
@pmakani pmakani requested review from a team and stephaniewang526 October 15, 2020 08:06
@pmakani pmakani requested a review from a team as a code owner October 15, 2020 08:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #803 into master will increase coverage by 0.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #803 +/- ## ============================================ + Coverage 80.42% 80.44% +0.01%  - Complexity 1266 1268 +2  ============================================ Files 79 79 Lines 6534 6545 +11 Branches 747 749 +2 ============================================ + Hits 5255 5265 +10  Misses 888 888 - Partials 391 392 +1
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/HivePartitioningOptions.java 85.41% <90.90%> (+1.63%) 13.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fa96a...6a2fefa. Read the comment docs.
@stephaniewang526 stephaniewang526 merged commit 193c886 into googleapis:master Oct 15, 2020
@pmakani pmakani deleted the bigquery-251 branch October 16, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

2 participants

@pmakani @stephaniewang526