Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Aug 19, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #681

@pmakani pmakani requested review from a team and stephaniewang526 August 19, 2020 17:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #682 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #682 +/- ## ========================================= Coverage 81.49% 81.49% Complexity 1226 1226 ========================================= Files 77 77 Lines 6220 6220 Branches 691 691 ========================================= Hits 5069 5069 Misses 792 792 Partials 359 359 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5acb756...bb378a4. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 19, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fe5abc0 into googleapis:master Aug 19, 2020
@pmakani pmakani deleted the fix-checkstyle branch August 20, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

3 participants