Skip to content

docs(samples): add update routine #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

docs(samples): add update routine #618

merged 1 commit into from
Jul 30, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 29, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@pmakani pmakani requested review from a team and stephaniewang526 July 29, 2020 13:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@stephaniewang526
Copy link
Contributor

some ITs are failing
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #618 +/- ## ========================================= Coverage 81.49% 81.49% Complexity 1226 1226 ========================================= Files 77 77 Lines 6220 6220 Branches 691 691 ========================================= Hits 5069 5069 Misses 792 792 Partials 359 359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873163e...e3cf945. Read the comment docs.
@stephaniewang526 stephaniewang526 merged commit a889800 into googleapis:master Jul 30, 2020
@pmakani pmakani deleted the update-routine branch July 30, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants

@pmakani @stephaniewang526 @yoshi-kokoro