Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 21, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@pmakani pmakani requested a review from stephaniewang526 July 21, 2020 14:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2020
@pmakani pmakani marked this pull request as ready for review July 21, 2020 14:50
@pmakani pmakani requested a review from a team July 21, 2020 14:50
@stephaniewang526 stephaniewang526 merged commit 29b8a7f into googleapis:master Jul 21, 2020
@pmakani pmakani deleted the query-cmek branch July 22, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

2 participants