Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@pmakani pmakani requested review from a team and stephaniewang526 July 15, 2020 12:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #554 +/- ## ========================================= Coverage 81.49% 81.49% Complexity 1226 1226 ========================================= Files 77 77 Lines 6220 6220 Branches 691 691 ========================================= Hits 5069 5069 Misses 792 792 Partials 359 359 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e084ce0...767f124. Read the comment docs.

@pmakani pmakani requested a review from stephaniewang526 July 15, 2020 16:09
@stephaniewang526 stephaniewang526 merged commit b87cecf into googleapis:master Jul 15, 2020
@pmakani pmakani deleted the list-jobs branch July 16, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants