Skip to content

fix: fieldvalue gettimestamp #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix: fieldvalue gettimestamp #279

merged 1 commit into from
Apr 16, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Apr 16, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #279 +/- ## ========================================= Coverage 77.53% 77.54% Complexity 1151 1151 ========================================= Files 75 75 Lines 6089 6091 +2 Branches 654 654 ========================================= + Hits 4721 4723 +2  Misses 1019 1019 Partials 349 349
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/bigquery/FieldValue.java 82.75% <100.00%> (+0.61%) 24.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e89ab...5b914fa. Read the comment docs.
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4478a23 into googleapis:master Apr 16, 2020
@pmakani pmakani deleted the bigquery-16 branch April 17, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

4 participants

@pmakani @stephaniewang526 @googlebot @yoshi-kokoro