Skip to content

Commit 3db013e

Browse files
authored
feat!: update dependency com.google.cloud:google-cloud-shared-config to v1 (#1466)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `0.13.1` -> `1.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.0.0/compatibility-slim/0.13.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.0.0/confidence-slim/0.13.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.0.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;100-httpswwwgithubcomgoogleapisjava-shared-configcomparev0131v100-2021-07-29) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.13.1...v1.0.0) ##### ⚠ BREAKING CHANGES - update shared-config to java 1.8 ([#&#8203;277](https://togithub.com/googleapis/java-shared-config/issues/277)) ##### Features - update shared-config to java 1.8 ([#&#8203;277](https://www.github.com/googleapis/java-shared-config/issues/277)) ([9c297a2](https://www.github.com/googleapis/java-shared-config/commit/9c297a27bc236092aab3ae292c7bed206293bc51)) ##### [0.13.1](https://www.github.com/googleapis/java-shared-config/compare/v0.13.0...v0.13.1) (2021-07-27) ##### Bug Fixes - revert update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.2.0 ([#&#8203;280](https://www.github.com/googleapis/java-shared-config/issues/280)) ([bdbbb9c](https://www.github.com/googleapis/java-shared-config/commit/bdbbb9c13571d0ef06009ebf03bc25c6e6fcbc17)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquery).
1 parent 563c30f commit 3db013e

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/JobStatisticsTest.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -322,26 +322,31 @@ public void testIncomplete() {
322322
new com.google.api.services.bigquery.model.JobStatistics()
323323
.setCreationTime(1234L)
324324
.setStartTime(5678L));
325+
JobStatistics jobStatistics;
325326

326327
job.setConfiguration(
327328
new com.google.api.services.bigquery.model.JobConfiguration()
328329
.setCopy(new com.google.api.services.bigquery.model.JobConfigurationTableCopy()));
329-
assertThat(JobStatistics.fromPb(job)).isInstanceOf(CopyStatistics.class);
330+
jobStatistics = JobStatistics.fromPb(job);
331+
assertThat(jobStatistics).isInstanceOf(CopyStatistics.class);
330332

331333
job.setConfiguration(
332334
new com.google.api.services.bigquery.model.JobConfiguration()
333335
.setLoad(new com.google.api.services.bigquery.model.JobConfigurationLoad()));
334-
assertThat(JobStatistics.fromPb(job)).isInstanceOf(LoadStatistics.class);
336+
jobStatistics = JobStatistics.fromPb(job);
337+
assertThat(jobStatistics).isInstanceOf(LoadStatistics.class);
335338

336339
job.setConfiguration(
337340
new com.google.api.services.bigquery.model.JobConfiguration()
338341
.setExtract(new com.google.api.services.bigquery.model.JobConfigurationExtract()));
339-
assertThat(JobStatistics.fromPb(job)).isInstanceOf(ExtractStatistics.class);
342+
jobStatistics = JobStatistics.fromPb(job);
343+
assertThat(jobStatistics).isInstanceOf(ExtractStatistics.class);
340344

341345
job.setConfiguration(
342346
new com.google.api.services.bigquery.model.JobConfiguration()
343347
.setQuery(new com.google.api.services.bigquery.model.JobConfigurationQuery()));
344-
assertThat(JobStatistics.fromPb(job)).isInstanceOf(QueryStatistics.class);
348+
jobStatistics = JobStatistics.fromPb(job);
349+
assertThat(jobStatistics).isInstanceOf(QueryStatistics.class);
345350
}
346351

347352
private void compareExtractStatistics(ExtractStatistics expected, ExtractStatistics value) {

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,11 +1202,9 @@ public void testUpdateTimePartitioning() {
12021202
.build();
12031203

12041204
Table table = bigquery.create(TableInfo.of(tableId, tableDefinition));
1205-
assertThat(table.getDefinition()).isInstanceOf(StandardTableDefinition.class);
1206-
assertThat(
1207-
((StandardTableDefinition) table.getDefinition())
1208-
.getTimePartitioning()
1209-
.getExpirationMs())
1205+
TableDefinition definition = table.getDefinition();
1206+
assertThat(definition).isInstanceOf(StandardTableDefinition.class);
1207+
assertThat(((StandardTableDefinition) definition).getTimePartitioning().getExpirationMs())
12101208
.isNull();
12111209

12121210
table =
@@ -1219,10 +1217,9 @@ public void testUpdateTimePartitioning() {
12191217
.build())
12201218
.build()
12211219
.update(BigQuery.TableOption.fields(BigQuery.TableField.TIME_PARTITIONING));
1220+
TableDefinition updatedDefinition = table.getDefinition();
12221221
assertThat(
1223-
((StandardTableDefinition) table.getDefinition())
1224-
.getTimePartitioning()
1225-
.getExpirationMs())
1222+
((StandardTableDefinition) updatedDefinition).getTimePartitioning().getExpirationMs())
12261223
.isEqualTo(42L);
12271224

12281225
table =
@@ -1235,10 +1232,7 @@ public void testUpdateTimePartitioning() {
12351232
.build())
12361233
.build()
12371234
.update(BigQuery.TableOption.fields(BigQuery.TableField.TIME_PARTITIONING));
1238-
assertThat(
1239-
((StandardTableDefinition) table.getDefinition())
1240-
.getTimePartitioning()
1241-
.getExpirationMs())
1235+
assertThat(((StandardTableDefinition) definition).getTimePartitioning().getExpirationMs())
12421236
.isNull();
12431237

12441238
table.delete();

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<parent>
1515
<groupId>com.google.cloud</groupId>
1616
<artifactId>google-cloud-shared-config</artifactId>
17-
<version>0.13.1</version>
17+
<version>1.0.0</version>
1818
</parent>
1919

2020
<developers>

0 commit comments

Comments
 (0)