Skip to content

feat: decode uri path components correctly #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2019
Merged

feat: decode uri path components correctly #913

merged 3 commits into from
Dec 17, 2019

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 10, 2019

The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.

Fixes #398
@codyoss
feat: decode uri path components correctly
875356d 
The old implementation was incorrecly treating '+' as a space. Now the only things that get decoded in the path are uri escaped sequences. Fixes googleapis#398
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@codyoss codyoss marked this pull request as ready for review December 10, 2019 23:03
@codyoss codyoss requested a review from a team as a code owner December 10, 2019 23:03
elharo
elharo reviewed Dec 10, 2019
View reviewed changes
elharo
elharo reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could swear this is reinventing something that exists in Guava, but perhaps that's only in the internal version.
@codyoss codyoss requested a review from chingor13 December 16, 2019 16:29
@chingor13 chingor13 merged commit 7d4a048 into googleapis:master Dec 17, 2019
@dmitry-fa
Copy link
Contributor

dmitry-fa commented Jan 15, 2020 •
edited
Loading

This change caused the problem with using space in object names in java cloud storage:

googleapis/java-storage#53
googleapis/java-storage#57
googleapis/java-storage#121
@athakor
Copy link

athakor commented Feb 11, 2020

@dmitry-fa correct, one more issue related to this changes.
googleapis/java-storage#121
@codyoss codyoss deleted the generic-url branch February 2, 2022 15:52
@mihalyr
Copy link

mihalyr commented Feb 2, 2022

Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using google-http-client version 1.34.0 or older that includes this change. The problem is handling + signs in sheet titles that lead to API failures when trying to append cells to a sheet that contains + in the title. This was working well before this change.

It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets.
@mihalyr mihalyr mentioned this pull request Feb 7, 2022
Closed
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-javadoc…
65795ce 
…-plugin to v3.4.0 (googleapis#913) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-javadoc-plugin)) | `3.3.2` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/compatibility-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.0/confidence-slim/3.3.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
@ldetmer ldetmer mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

7 participants

@codyoss @dmitry-fa @athakor @mihalyr @chingor13 @elharo @googlebot