Skip to content

Fix declared dependencies from merge issue #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Jul 11, 2019
Merged

Fix declared dependencies from merge issue #291

chingor13 merged 1 commit into from
Jul 11, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jul 9, 2019 •
edited
Loading

This direct dependency was added in #288, but the presubmit check was not yet set up. It was already being transitively pulled in via google-auth-library-oauth2-http
@chingor13 chingor13 requested a review from a team as a code owner July 9, 2019 22:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9b14268). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #291 +/- ## ========================================= Coverage ? 78.79% Complexity ? 340 ========================================= Files ? 21 Lines ? 1495 Branches ? 162 ========================================= Hits ? 1178 Misses ? 238 Partials ? 79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b14268...6a02c42. Read the comment docs.
@chingor13 chingor13 merged commit 35abf13 into googleapis:master Jul 11, 2019
@chingor13 chingor13 deleted the fix-dep branch July 11, 2019 15:50
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this pull request Jul 26, 2019
@chingor13
fix: declared dependencies from merge issue (googleapis#291)
047f0ae
@chingor13 chingor13 added the fix label Jul 26, 2019
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this pull request Jul 26, 2019
@chingor13
declared dependencies from merge issue (googleapis#291)
c3794fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. fix

3 participants

@chingor13 @kolea2 @googlebot