fix: replace '-' in method names with '_' #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
busunkim96 force-pushed the replace-hyphen-with-underscore branch from 516cf25 to 5b25b32 Compare 
| Hi @busunkim96, if this could be merged it would allow us to submit some Healthcare API PRs that this is blocking. |
crwilcox approved these changes Apr 17, 2020
| @busunkim96 After this goes in, do you know when the next client release will happen? |
| We have a 'no Friday releases' policy, so I'll cut it on Monday morning. Thank you for your patience! |
| Great, thanks. |
| @busunkim96 I am very happy that the release will appear soon. I'm waiting. :-D |
bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this pull request May 11, 2020
https://build.opensuse.org/request/show/802599 by user mcepl + dimstar_suse - Update to 1.8.2: - Remove apiclient.__version__ gh#googleapis/googleapis#870 - Adding ConnectionError to retry mechanism gh#googleapis/googleapis#558 - replace '-' in method names with '_' gh#googleapis/google-api-python-client#863 - Add missing dependency on oauth2client. - Fix filelist (no CHANGELOG anymore, missing README.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Healthcare API has a resource named 'Patient-everything' which is unaccessible because the hyphen makes it an invalid name.
https://healthcare.googleapis.com/$discovery/rest?version=v1
This change replaces the '-' with a '_'.
CC @noerog