Skip to content

Conversation

spathon
Copy link
Contributor

@spathon spathon commented Jul 15, 2021

Add the option to set vpcConnectorEgressSettings
VpcConnectorEgressSettings docs

Also added ingressSettings for #91 while I was in the code

@spathon spathon requested a review from a team as a code owner July 15, 2021 09:41
@google-cla
Copy link

google-cla bot commented Jul 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 15, 2021
@github-actions github-actions bot added the Fork label Jul 15, 2021
@spathon
Copy link
Contributor Author

spathon commented Jul 15, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 15, 2021
@spathon spathon changed the title feat: Add vpcConnectorEgressSettings option feat: Add vpcConnectorEgressSettings & ingressSettings options Jul 15, 2021
@bharathkkb bharathkkb changed the base branch from main to pr-112 July 21, 2021 16:35
@bharathkkb bharathkkb changed the base branch from pr-112 to main July 21, 2021 16:36
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spathon
Copy link
Contributor Author

spathon commented Jul 22, 2021

Thanks, I had missed those 2 places

@bharathkkb bharathkkb changed the base branch from main to pr-112 July 30, 2021 17:10
@bharathkkb bharathkkb merged commit e41a664 into google-github-actions:pr-112 Jul 30, 2021
bharathkkb added a commit that referenced this pull request Jul 30, 2021
…#141) * Add vpcConnectorEgressSettings option * fix #91 ingressSettings * Add input desc to action.yaml and readme Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com> Co-authored-by: Patrik Spathon <patrik@spathon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants