Skip to content

No callback to handle database_error event #57

@chrisbianca

Description

@chrisbianca

I've just been trying to get Firestack set up on a brand new project using the FirestackModule and have found an issue when a database permission error is thrown on iOS.

In database.js, a native success and error listener are added for "database_event" and "database_error". However, in FirestackDatabase.m, both the database events and errors are sent with the "database_event" identifier.

This means that an error is subsequently thrown in database.js as there is no callback registered against a "database_error" type.

I'm happy to submit a PR to make sure that FirestackDatabase.m sends the event as "database_error" but wanted to check there wasn't a reason they're currently sent with the same type before I did?

I'm assuming it's an oversight as the Java code appears to emit the two events separately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions