Limit post type choices to public types

Author: stracker-phil

src/wp-api.ts

@@ -14,7 +14,12 @@ export const enum PostTypeConst {
  Post = 'post',
  Page = 'page',
 }
-export type PostType = string;
+
+export interface PostTypeObj {
+ slug: string;
+ name: string;
+}
+export type PostType = string | PostTypeObj;
 
 export interface Term {
  id: string;

src/wp-publish-modal.ts

@@ -172,14 +172,21 @@ export class WpPublishModal extends AbstractModal {
  });
 
  if (!this.matterData?.postId) {
+ const defaultType = params.postType
+ const defaultTypeSlug = 'string' === typeof defaultType ? defaultType : defaultType.slug;
+
  new Setting(contentEl)
  .setName(this.t('publishModal_postType'))
  .addDropdown((dropdown) => {
  this.postTypes.items.forEach(it => {
- dropdown.addOption(it, it);
+ if ('string' === typeof it) {
+ dropdown.addOption(it, it);
+ } else {
+ dropdown.addOption(it.slug , it.name);
+ }
  });
  dropdown
- .setValue(params.postType)
+ .setValue(defaultTypeSlug)
  .onChange((value) => {
  params.postType = value as PostType;
  this.display(params);

src/wp-rest-client.ts

@@ -115,7 +115,7 @@ export class WpRestClient extends AbstractWordPressClient {
 
  async getPostTypes(certificate: WordPressAuthParams): Promise<PostType[]> {
  const data: SafeAny = await this.client.httpGet(
- getUrl(this.context.endpoints?.getPostTypes, 'wp-json/wp/v2/types'),
+ getUrl(this.context.endpoints?.getPostTypes, 'wp-json/wp/v2/types?context=edit'),
  {
  headers: this.context.getHeaders(certificate)
  });
@@ -290,7 +290,10 @@ class WpRestClientCommonContext implements WpRestClientContext {
  }),
  toPostTypes: (response: SafeAny): PostType[] => {
  if (isObject(response)) {
- return Object.keys(response);
+ return Object.entries(response)
+ // We only publish to viewable post types, and never to an attachment
+ .filter(([slug, { viewable }]) => viewable && 'attachment' !== slug)
+ .map(([slug, { labels :{singular_name} }]: [string, { labels: {singular_name: string} }]) => ({slug, name: singular_name}));
  }
  return [];
  }