[+] add tests (WIP)

Author: pashagolub

.github/prompts/implement.prompt.md

@@ -0,0 +1,32 @@
+# Execute tasks from the plan
+
+Execute tasks from the plan.
+
+This is the fourth step in the Spec-Driven Development lifecycle.
+
+Given the context provided as an argument, do this:
+
+1. Run `scripts/check-task-prerequisites.sh --json` from repo root and parse FEATURE_DIR and AVAILABLE_DOCS list. All paths must be absolute.
+2. Load and analyze available design documents:
+ - Always read plan.md for tech stack and libraries
+ - Read tasks.md for existing tasks
+ - IF EXISTS: Read data-model.md for entities
+ - IF EXISTS: Read contracts/ for API endpoints
+ - IF EXISTS: Read research.md for technical decisions
+ - IF EXISTS: Read quickstart.md for test scenarios
+
+ Note: Not all projects have all documents. For example:
+ - CLI tools might not have contracts/
+ - Simple libraries might not need data-model.md
+
+3. Implement tasks according to tasks.md and the context provided as an argument.
+
+4. If several tasks specified for implementing, order tasks by dependencies:
+ - Setup before everything
+ - Tests before implementation (TDD)
+ - Models before services
+ - Services before endpoints
+ - Core before integration
+ - Everything before polish
+
+Context for task implementation: $ARGUMENTS

Makefile

@@ -20,7 +20,7 @@ build:
 ## Run tests
 test:
 @echo "Running tests..."
-@go test -v -race -coverprofile=coverage.out ./...
+@go test -v -coverprofile=coverage.out ./...
 
 ## Run integration tests (requires PostgreSQL and etcd)
 test-integration:

cmd/etcd_fdw/cli_test.go

@@ -0,0 +1,171 @@
+// Package main provides CLI testing for etcd_fdw command-line interface.
+package main
+
+import (
+"os"
+"testing"
+
+"github.com/stretchr/testify/assert"
+"github.com/stretchr/testify/require"
+)
+
+// TestCLIParsing tests DSN parsing and flag validation for etcd_fdw CLI
+// This test MUST FAIL until CLI implementation is complete (TDD approach)
+func TestCLIParsing(t *testing.T) {
+tests := []struct {
+name string
+args []string
+wantErr bool
+errMsg string
+expected Config
+}{
+{
+name: "valid DSN and etcd DSN",
+args: []string{
+"--postgres-dsn", "postgres://user:pass@localhost:5432/db",
+"--etcd-dsn", "etcd://localhost:2379/",
+},
+wantErr: false,
+expected: Config{
+PostgresDSN: "postgres://user:pass@localhost:5432/db",
+EtcdDSN: "etcd://localhost:2379/",
+LogLevel: "info", // default value
+},
+},
+{
+name: "multiple etcd endpoints in DSN",
+args: []string{
+"--postgres-dsn", "postgres://user:pass@localhost:5432/db",
+"--etcd-dsn", "etcd://localhost:2379,localhost:2380,localhost:2381/",
+},
+wantErr: false,
+expected: Config{
+PostgresDSN: "postgres://user:pass@localhost:5432/db",
+EtcdDSN: "etcd://localhost:2379,localhost:2380,localhost:2381/",
+LogLevel: "info", // default value
+},
+},
+{
+name: "help flag",
+args: []string{"--help"},
+wantErr: false,
+expected: Config{
+Help: true,
+LogLevel: "info", // default value
+},
+},
+{
+name: "version flag",
+args: []string{"--version"},
+wantErr: false,
+expected: Config{
+Version: true,
+LogLevel: "info", // default value
+},
+},
+{
+name: "with log level and dry run",
+args: []string{
+"--postgres-dsn", "postgres://user:pass@localhost:5432/db",
+"--etcd-dsn", "etcd://localhost:2379/",
+"--log-level", "debug",
+"--dry-run",
+},
+wantErr: false,
+expected: Config{
+PostgresDSN: "postgres://user:pass@localhost:5432/db",
+EtcdDSN: "etcd://localhost:2379/",
+LogLevel: "debug",
+DryRun: true,
+},
+},
+{
+name: "etcd DSN with prefix and TLS params",
+args: []string{
+"--postgres-dsn", "postgres://user:pass@localhost:5432/db",
+"--etcd-dsn", "etcd://localhost:2379/config/?tls=enabled&dial_timeout=5s",
+},
+wantErr: false,
+expected: Config{
+PostgresDSN: "postgres://user:pass@localhost:5432/db",
+EtcdDSN: "etcd://localhost:2379/config/?tls=enabled&dial_timeout=5s",
+LogLevel: "info", // default value
+},
+},
+{
+name: "short flag aliases",
+args: []string{
+"-p", "postgres://user:pass@localhost:5432/db",
+"-e", "etcd://localhost:2379/",
+"-l", "warn",
+},
+wantErr: false,
+expected: Config{
+PostgresDSN: "postgres://user:pass@localhost:5432/db",
+EtcdDSN: "etcd://localhost:2379/",
+LogLevel: "warn",
+},
+},
+}
+
+for _, tt := range tests {
+t.Run(tt.name, func(t *testing.T) {
+config, err := ParseCLI(tt.args)
+
+if tt.wantErr {
+require.Error(t, err, "Expected error for test case: %s", tt.name)
+if tt.errMsg != "" {
+assert.Contains(t, err.Error(), tt.errMsg, "Error message should contain expected text")
+}
+} else {
+require.NoError(t, err, "Expected no error for test case: %s", tt.name)
+require.NotNil(t, config, "Config should not be nil")
+assert.Equal(t, tt.expected, *config, "Parsed config should match expected")
+}
+})
+}
+}
+
+// TestCLIEnvironmentVariables tests that CLI can read from environment variables
+func TestCLIEnvironmentVariables(t *testing.T) {
+// Set environment variables
+os.Setenv("ETCD_FDW_POSTGRES_DSN", "postgres://env:pass@localhost:5432/envdb")
+os.Setenv("ETCD_FDW_ETCD_DSN", "etcd://localhost:2379,localhost:2380/")
+defer func() {
+os.Unsetenv("ETCD_FDW_POSTGRES_DSN")
+os.Unsetenv("ETCD_FDW_ETCD_DSN")
+}()
+
+// This will fail because ParseCLI function doesn't exist yet
+config, err := ParseCLI([]string{})
+
+require.NoError(t, err, "Should parse from environment variables")
+require.NotNil(t, config, "Config should not be nil")
+assert.Equal(t, "postgres://env:pass@localhost:5432/envdb", config.PostgresDSN)
+assert.Equal(t, "etcd://localhost:2379,localhost:2380/", config.EtcdDSN)
+}
+
+// TestCLIFlagPrecedence tests that command-line flags override environment variables
+func TestCLIFlagPrecedence(t *testing.T) {
+// Set environment variables
+os.Setenv("ETCD_FDW_POSTGRES_DSN", "postgres://env:pass@localhost:5432/envdb")
+os.Setenv("ETCD_FDW_ETCD_DSN", "etcd://localhost:2379/")
+defer func() {
+os.Unsetenv("ETCD_FDW_POSTGRES_DSN")
+os.Unsetenv("ETCD_FDW_ETCD_DSN")
+}()
+
+// Command-line flags should override environment
+args := []string{
+"--postgres-dsn", "postgres://flag:pass@localhost:5432/flagdb",
+"--etcd-dsn", "etcd://localhost:2380/",
+}
+
+// This will fail because ParseCLI function doesn't exist yet
+config, err := ParseCLI(args)
+
+require.NoError(t, err, "Should parse with flag precedence")
+require.NotNil(t, config, "Config should not be nil")
+assert.Equal(t, "postgres://flag:pass@localhost:5432/flagdb", config.PostgresDSN)
+assert.Equal(t, "etcd://localhost:2380/", config.EtcdDSN)
+}