Feature Fix #194
Merged
Feature Fix #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Laravel 12 compatibility issues by updating the cache driver configuration to support the new CACHE_STORE environment variable while maintaining backward compatibility with older Laravel versions. It also fixes a nullable language field in the TextshotPage DTO.
- Updated cache configuration to prioritize
CACHE_STOREoverCACHE_DRIVERfor Laravel 12 compatibility - Modified TextshotPage DTO to accept nullable language parameter
- Added comprehensive test coverage for the new cache configuration behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DTO/TextshotPage.php | Modified constructor to allow nullable language parameter |
| config/laravel-docuware.php | Updated cache driver configuration with fallback chain for Laravel 12 compatibility |
| README.md | Updated documentation to reflect new cache configuration pattern |
| CHANGELOG.md | Added release notes documenting Laravel 12 compatibility changes |
| .phpunit.cache/test-results | Test results showing new cache compatibility tests |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.