Skip to content

Commit fcbc348

Browse files
committed
updated to hone optimizations branch and added option
1 parent a8c27d9 commit fcbc348

File tree

9 files changed

+32
-32
lines changed

9 files changed

+32
-32
lines changed

app/tour-config-provider.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export default function TourConfig() {
1616
backdrop: false,
1717
backdropZIndex: 10000,
1818
backdropPadding: '0px',
19+
disableBackdropOptimizations: false,
1920
scrollOffset: 100,
2021
scrollIntoView: true,
2122
useUiRouter: false,

app/tour-directive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default function uiTourDirective(TourHelpers) {
1414
name: attrs.uiTour
1515
},
1616
events = 'onReady onStart onEnd onShow onShown onHide onHidden onNext onPrev onPause onResume onBackdropClick'.split(' '),
17-
properties = 'placement animation popupDelay closePopupDelay enable appendToBody popupClass orphan backdrop backdropBorderRadius backdropPadding scrollParentId scrollOffset scrollIntoView useUiRouter useHotkeys'.split(' ');
17+
properties = 'placement animation popupDelay closePopupDelay enable appendToBody popupClass orphan backdrop backdropBorderRadius backdropPadding disableBackdropOptimizations scrollParentId scrollOffset scrollIntoView useUiRouter useHotkeys'.split(' ');
1818

1919
//Pass interpolated values through
2020
TourHelpers.attachInterpolatedValues(attrs, tour, properties, 'uiTour');

app/tour-step-directive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default function tourStepDirective(TourHelpers, uiTourService, $sce) {
1414
//Assign required options
1515
step,
1616
events = 'onShow onShown onHide onHidden onNext onPrev onBackdropClick'.split(' '),
17-
options = 'content title animation placement backdrop backdropBorderRadius backdropPadding orphan popupDelay popupCloseDelay popupClass fixed preventScrolling scrollIntoView nextStep prevStep nextPath prevPath scrollOffset scrollParentId'.split(' '),
17+
options = 'content title animation placement backdrop backdropBorderRadius backdropPadding disableBackdropOptimizations orphan popupDelay popupCloseDelay popupClass fixed preventScrolling scrollIntoView nextStep prevStep nextPath prevPath scrollOffset scrollParentId'.split(' '),
1818
orderWatch,
1919
enabledWatch,
2020
contentWatch;

app/tour-step-service.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ export default function (Tether, $compile, $document, $templateCache, $rootScope
159159
borderRadius: step.config('backdropBorderRadius'),
160160
padding: step.config('backdropPadding'),
161161
fullScreen: step.config('orphan'),
162+
disableOptimizations: step.config('disableBackdropOptimizations'),
162163
events: {
163164
click: step.config('onBackdropClick')
164165
}

dist/angular-ui-tour.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,6 +851,7 @@ function TourConfig() {
851851
backdrop: false,
852852
backdropZIndex: 10000,
853853
backdropPadding: '0px',
854+
disableBackdropOptimizations: false,
854855
scrollOffset: 100,
855856
scrollIntoView: true,
856857
useUiRouter: false,
@@ -1449,6 +1450,7 @@ exports.default = ["Tether", "$compile", "$document", "$templateCache", "$rootSc
14491450
borderRadius: step.config('backdropBorderRadius'),
14501451
padding: step.config('backdropPadding'),
14511452
fullScreen: step.config('orphan'),
1453+
disableOptimizations: step.config('disableBackdropOptimizations'),
14521454
events: {
14531455
click: step.config('onBackdropClick')
14541456
}
@@ -2494,7 +2496,7 @@ function uiTourDirective(TourHelpers) {
24942496
name: attrs.uiTour
24952497
},
24962498
events = 'onReady onStart onEnd onShow onShown onHide onHidden onNext onPrev onPause onResume onBackdropClick'.split(' '),
2497-
properties = 'placement animation popupDelay closePopupDelay enable appendToBody popupClass orphan backdrop backdropBorderRadius backdropPadding scrollParentId scrollOffset scrollIntoView useUiRouter useHotkeys'.split(' ');
2499+
properties = 'placement animation popupDelay closePopupDelay enable appendToBody popupClass orphan backdrop backdropBorderRadius backdropPadding disableBackdropOptimizations scrollParentId scrollOffset scrollIntoView useUiRouter useHotkeys'.split(' ');
24982500

24992501
//Pass interpolated values through
25002502
TourHelpers.attachInterpolatedValues(attrs, tour, properties, 'uiTour');
@@ -2561,7 +2563,7 @@ function tourStepDirective(TourHelpers, uiTourService, $sce) {
25612563
//Assign required options
25622564
step,
25632565
events = 'onShow onShown onHide onHidden onNext onPrev onBackdropClick'.split(' '),
2564-
options = 'content title animation placement backdrop backdropBorderRadius backdropPadding orphan popupDelay popupCloseDelay popupClass fixed preventScrolling scrollIntoView nextStep prevStep nextPath prevPath scrollOffset scrollParentId'.split(' '),
2566+
options = 'content title animation placement backdrop backdropBorderRadius backdropPadding disableBackdropOptimizations orphan popupDelay popupCloseDelay popupClass fixed preventScrolling scrollIntoView nextStep prevStep nextPath prevPath scrollOffset scrollParentId'.split(' '),
25652567
orderWatch,
25662568
enabledWatch,
25672569
contentWatch;

karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ module.exports = function (config) {
8888

8989
// start these browsers
9090
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
91-
browsers: ['PhantomJS'],
91+
browsers: ['ChromeHeadless'],
9292

9393

9494
// Continuous Integration mode

package-lock.json

Lines changed: 19 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"angular-sanitize": ">=1.5",
4242
"angular-hotkeys": "1.7.0",
4343
"angular-scroll": "1.0.2",
44-
"hone": "1.0.3",
44+
"hone": "git+https://github.com/benmarch/hone.git#optional-optimizations",
4545
"tether": "1.4.0",
4646
"angular-bind-html-compile": "https://github.com/incuna/angular-bind-html-compile.git#1.4.1"
4747
},

webpack.config.babel.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ let config = {
1717
library: libraryName,
1818
libraryTarget: 'umd'
1919
},
20+
resolve: {
21+
mainFields: ['jsnext:main', 'main']
22+
},
2023
externals: {
2124
"angular": "angular",
2225
"angular-hotkeys": "angular-hotkeys",

0 commit comments

Comments
 (0)