Service discovery - remove dependency on memfd_create #9913

raphaelgavache · 2025-11-06T22:47:56Z

What Does This Do

memfd_create was introduced in glibc 2.27, meaning that on distros before and including centos7, debian8, amazonlinux2 the JNA logic triggers an exception while searching for the symbol. The exception is caught on purpose by the try-catch but it is still collected in the crash tracking initiative.

Removing it by calling directly the syscall

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-11-06T23:07:44Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.31% (+3.71%)

View detailed report

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1bd59c4 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-11-06T23:35:50Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	raphael/add_id_memfd
git_commit_date	1762544894	1762549451
git_commit_sha	`f132c86`	`1bd59c4`
release_version	1.56.0-SNAPSHOT~f132c86c16	1.56.0-SNAPSHOT~1bd59c4f94

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762551276	1762551276
ci_job_id	1223525126	1223525126
ci_pipeline_id	81663661	81663661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-1ras7kpx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-1ras7kpx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section tracing Agent [baseline] (1.05 s) : 0, 1050227 Total [baseline] (8.639 s) : 0, 8638514 Agent [candidate] (1.05 s) : 0, 1049539 Total [candidate] (8.635 s) : 0, 8634789 section iast Agent [baseline] (1.178 s) : 0, 1177760 Total [baseline] (9.263 s) : 0, 9262794 Agent [candidate] (1.18 s) : 0, 1180284 Total [candidate] (9.261 s) : 0, 9260519

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.178 s	127.533 ms (12.1%)
Total	tracing	8.639 s	-
Total	iast	9.263 s	624.28 ms (7.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.18 s	130.745 ms (12.5%)
Total	tracing	8.635 s	-
Total	iast	9.261 s	625.73 ms (7.2%)

gantt title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.457 ms) : 0, 1457 crashtracking [candidate] (1.46 ms) : 0, 1460 BytebuddyAgent [baseline] (707.045 ms) : 0, 707045 BytebuddyAgent [candidate] (706.942 ms) : 0, 706942 GlobalTracer [baseline] (246.202 ms) : 0, 246202 GlobalTracer [candidate] (246.602 ms) : 0, 246602 AppSec [baseline] (32.435 ms) : 0, 32435 AppSec [candidate] (32.373 ms) : 0, 32373 Debugger [baseline] (6.456 ms) : 0, 6456 Debugger [candidate] (6.367 ms) : 0, 6367 Remote Config [baseline] (730.397 µs) : 0, 730 Remote Config [candidate] (724.806 µs) : 0, 725 Telemetry [baseline] (16.067 ms) : 0, 16067 Telemetry [candidate] (13.735 ms) : 0, 13735 Flare Poller [baseline] (5.043 ms) : 0, 5043 Flare Poller [candidate] (6.597 ms) : 0, 6597 section iast crashtracking [baseline] (1.451 ms) : 0, 1451 crashtracking [candidate] (1.451 ms) : 0, 1451 BytebuddyAgent [baseline] (827.38 ms) : 0, 827380 BytebuddyAgent [candidate] (829.321 ms) : 0, 829321 GlobalTracer [baseline] (233.916 ms) : 0, 233916 GlobalTracer [candidate] (234.845 ms) : 0, 234845 AppSec [baseline] (27.004 ms) : 0, 27004 AppSec [candidate] (28.615 ms) : 0, 28615 Debugger [baseline] (5.982 ms) : 0, 5982 Debugger [candidate] (6.01 ms) : 0, 6010 Remote Config [baseline] (596.849 µs) : 0, 597 Remote Config [candidate] (599.018 µs) : 0, 599 Telemetry [baseline] (8.316 ms) : 0, 8316 Telemetry [candidate] (8.394 ms) : 0, 8394 Flare Poller [baseline] (4.133 ms) : 0, 4133 Flare Poller [candidate] (4.175 ms) : 0, 4175 IAST [baseline] (34.245 ms) : 0, 34245 IAST [candidate] (32.187 ms) : 0, 32187

Startup time reports for petclinic

gantt title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section tracing Agent [baseline] (1.048 s) : 0, 1047573 Total [baseline] (10.681 s) : 0, 10680975 Agent [candidate] (1.051 s) : 0, 1050634 Total [candidate] (10.773 s) : 0, 10773074 section appsec Agent [baseline] (1.221 s) : 0, 1220834 Total [baseline] (10.824 s) : 0, 10824135 Agent [candidate] (1.221 s) : 0, 1221091 Total [candidate] (10.844 s) : 0, 10844346 section iast Agent [baseline] (1.2 s) : 0, 1200394 Total [baseline] (11.128 s) : 0, 11128000 Agent [candidate] (1.178 s) : 0, 1177791 Total [candidate] (11.096 s) : 0, 11095845 section profiling Agent [baseline] (1.2 s) : 0, 1199658 Total [baseline] (10.888 s) : 0, 10887637 Agent [candidate] (1.194 s) : 0, 1194134 Total [candidate] (10.926 s) : 0, 10926453

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.221 s	173.261 ms (16.5%)
Agent	iast	1.2 s	152.821 ms (14.6%)
Agent	profiling	1.2 s	152.085 ms (14.5%)
Total	tracing	10.681 s	-
Total	appsec	10.824 s	143.16 ms (1.3%)
Total	iast	11.128 s	447.025 ms (4.2%)
Total	profiling	10.888 s	206.662 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.221 s	170.457 ms (16.2%)
Agent	iast	1.178 s	127.157 ms (12.1%)
Agent	profiling	1.194 s	143.5 ms (13.7%)
Total	tracing	10.773 s	-
Total	appsec	10.844 s	71.272 ms (0.7%)
Total	iast	11.096 s	322.771 ms (3.0%)
Total	profiling	10.926 s	153.378 ms (1.4%)

gantt title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.455 ms) : 0, 1455 crashtracking [candidate] (1.467 ms) : 0, 1467 BytebuddyAgent [baseline] (705.141 ms) : 0, 705141 BytebuddyAgent [candidate] (707.048 ms) : 0, 707048 GlobalTracer [baseline] (245.75 ms) : 0, 245750 GlobalTracer [candidate] (246.524 ms) : 0, 246524 AppSec [baseline] (32.597 ms) : 0, 32597 AppSec [candidate] (32.52 ms) : 0, 32520 Debugger [baseline] (6.407 ms) : 0, 6407 Debugger [candidate] (6.437 ms) : 0, 6437 Remote Config [baseline] (719.588 µs) : 0, 720 Remote Config [candidate] (706.407 µs) : 0, 706 Telemetry [baseline] (15.642 ms) : 0, 15642 Telemetry [candidate] (13.789 ms) : 0, 13789 Flare Poller [baseline] (5.133 ms) : 0, 5133 Flare Poller [candidate] (7.442 ms) : 0, 7442 section appsec crashtracking [baseline] (1.462 ms) : 0, 1462 crashtracking [candidate] (1.451 ms) : 0, 1451 BytebuddyAgent [baseline] (728.806 ms) : 0, 728806 BytebuddyAgent [candidate] (728.25 ms) : 0, 728250 GlobalTracer [baseline] (237.17 ms) : 0, 237170 GlobalTracer [candidate] (237.261 ms) : 0, 237261 AppSec [baseline] (174.641 ms) : 0, 174641 AppSec [candidate] (175.17 ms) : 0, 175170 Debugger [baseline] (5.964 ms) : 0, 5964 Debugger [candidate] (6.016 ms) : 0, 6016 Remote Config [baseline] (646.602 µs) : 0, 647 Remote Config [candidate] (652.762 µs) : 0, 653 Telemetry [baseline] (8.459 ms) : 0, 8459 Telemetry [candidate] (8.62 ms) : 0, 8620 Flare Poller [baseline] (3.975 ms) : 0, 3975 Flare Poller [candidate] (4.002 ms) : 0, 4002 IAST [baseline] (24.782 ms) : 0, 24782 IAST [candidate] (24.745 ms) : 0, 24745 section iast crashtracking [baseline] (1.487 ms) : 0, 1487 crashtracking [candidate] (1.453 ms) : 0, 1453 BytebuddyAgent [baseline] (844.649 ms) : 0, 844649 BytebuddyAgent [candidate] (827.124 ms) : 0, 827124 GlobalTracer [baseline] (238.136 ms) : 0, 238136 GlobalTracer [candidate] (234.729 ms) : 0, 234729 AppSec [baseline] (28.822 ms) : 0, 28822 AppSec [candidate] (27.748 ms) : 0, 27748 Debugger [baseline] (6.065 ms) : 0, 6065 Debugger [candidate] (5.94 ms) : 0, 5940 Remote Config [baseline] (611.478 µs) : 0, 611 Remote Config [candidate] (594.704 µs) : 0, 595 Telemetry [baseline] (8.521 ms) : 0, 8521 Telemetry [candidate] (8.289 ms) : 0, 8289 Flare Poller [baseline] (4.134 ms) : 0, 4134 Flare Poller [candidate] (4.089 ms) : 0, 4089 IAST [baseline] (32.757 ms) : 0, 32757 IAST [candidate] (33.141 ms) : 0, 33141 section profiling ProfilingAgent [baseline] (110.692 ms) : 0, 110692 ProfilingAgent [candidate] (110.537 ms) : 0, 110537 crashtracking [baseline] (1.447 ms) : 0, 1447 crashtracking [candidate] (1.447 ms) : 0, 1447 BytebuddyAgent [baseline] (734.133 ms) : 0, 734133 BytebuddyAgent [candidate] (730.611 ms) : 0, 730611 GlobalTracer [baseline] (222.929 ms) : 0, 222929 GlobalTracer [candidate] (222.173 ms) : 0, 222173 AppSec [baseline] (32.4 ms) : 0, 32400 AppSec [candidate] (32.024 ms) : 0, 32024 Debugger [baseline] (9.113 ms) : 0, 9113 Debugger [candidate] (9.574 ms) : 0, 9574 Remote Config [baseline] (709.84 µs) : 0, 710 Remote Config [candidate] (671.897 µs) : 0, 672 Telemetry [baseline] (13.864 ms) : 0, 13864 Telemetry [candidate] (13.072 ms) : 0, 13072 Flare Poller [baseline] (4.157 ms) : 0, 4157 Flare Poller [candidate] (4.095 ms) : 0, 4095 Profiling [baseline] (111.359 ms) : 0, 111359 Profiling [candidate] (111.204 ms) : 0, 111204

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	raphael/add_id_memfd
git_commit_date	1762544894	1762549451
git_commit_sha	`f132c86`	`1bd59c4`
release_version	1.56.0-SNAPSHOT~f132c86c16	1.56.0-SNAPSHOT~1bd59c4f94

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762551777	1762551777
ci_job_id	1223525127	1223525127
ci_pipeline_id	81663661	81663661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-fyz2yu9e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-fyz2yu9e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+77.772µs; +117.735µs] or [+3.816%; +5.776%]	unstable [-360.383op/s; +163.508op/s] or [-16.267%; +7.380%]	2.136ms	2116.969op/s	2.038ms	2215.406op/s
scenario:load:petclinic:appsec:high_load	worse [+1.095ms; +1.526ms] or [+5.868%; +8.176%]	unstable [-41.010op/s; +8.448op/s] or [-16.400%; +3.378%]	19.972ms	233.781op/s	18.662ms	250.062op/s
scenario:load:petclinic:iast:high_load	worse [+0.897ms; +1.290ms] or [+5.073%; +7.295%]	unstable [-41.150op/s; +10.650op/s] or [-15.600%; +4.037%]	18.782ms	248.531op/s	17.688ms	263.781op/s

Request duration reports for petclinic

gantt title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section baseline no_agent (18.435 ms) : 18246, 18624 . : milestone, 18435, appsec (18.662 ms) : 18468, 18856 . : milestone, 18662, code_origins (17.562 ms) : 17389, 17735 . : milestone, 17562, iast (17.688 ms) : 17510, 17866 . : milestone, 17688, profiling (18.717 ms) : 18530, 18905 . : milestone, 18717, tracing (17.377 ms) : 17206, 17547 . : milestone, 17377, section candidate no_agent (18.081 ms) : 17899, 18263 . : milestone, 18081, appsec (19.972 ms) : 19766, 20178 . : milestone, 19972, code_origins (17.692 ms) : 17517, 17866 . : milestone, 17692, iast (18.782 ms) : 18595, 18969 . : milestone, 18782, profiling (18.245 ms) : 18062, 18428 . : milestone, 18245, tracing (17.562 ms) : 17388, 17736 . : milestone, 17562,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.435 ms [18.246 ms, 18.624 ms]	-
appsec	18.662 ms [18.468 ms, 18.856 ms]	226.55 µs (1.2%)
code_origins	17.562 ms [17.389 ms, 17.735 ms]	-873.357 µs (-4.7%)
iast	17.688 ms [17.51 ms, 17.866 ms]	-746.984 µs (-4.1%)
profiling	18.717 ms [18.53 ms, 18.905 ms]	282.304 µs (1.5%)
tracing	17.377 ms [17.206 ms, 17.547 ms]	-1.058 ms (-5.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.081 ms [17.899 ms, 18.263 ms]	-
appsec	19.972 ms [19.766 ms, 20.178 ms]	1.891 ms (10.5%)
code_origins	17.692 ms [17.517 ms, 17.866 ms]	-389.232 µs (-2.2%)
iast	18.782 ms [18.595 ms, 18.969 ms]	701.077 µs (3.9%)
profiling	18.245 ms [18.062 ms, 18.428 ms]	164.224 µs (0.9%)
tracing	17.562 ms [17.388 ms, 17.736 ms]	-518.996 µs (-2.9%)

Request duration reports for insecure-bank

gantt title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section baseline no_agent (1.194 ms) : 1182, 1206 . : milestone, 1194, iast (3.099 ms) : 3060, 3137 . : milestone, 3099, iast_FULL (5.82 ms) : 5762, 5878 . : milestone, 5820, iast_GLOBAL (3.561 ms) : 3509, 3612 . : milestone, 3561, profiling (2.038 ms) : 2020, 2056 . : milestone, 2038, tracing (1.767 ms) : 1753, 1781 . : milestone, 1767, section candidate no_agent (1.218 ms) : 1206, 1231 . : milestone, 1218, iast (3.189 ms) : 3152, 3226 . : milestone, 3189, iast_FULL (5.923 ms) : 5864, 5983 . : milestone, 5923, iast_GLOBAL (3.559 ms) : 3500, 3618 . : milestone, 3559, profiling (2.136 ms) : 2117, 2155 . : milestone, 2136, tracing (1.792 ms) : 1778, 1806 . : milestone, 1792,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.194 ms [1.182 ms, 1.206 ms]	-
iast	3.099 ms [3.06 ms, 3.137 ms]	1.904 ms (159.5%)
iast_FULL	5.82 ms [5.762 ms, 5.878 ms]	4.626 ms (387.3%)
iast_GLOBAL	3.561 ms [3.509 ms, 3.612 ms]	2.367 ms (198.2%)
profiling	2.038 ms [2.02 ms, 2.056 ms]	843.924 µs (70.7%)
tracing	1.767 ms [1.753 ms, 1.781 ms]	572.787 µs (48.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.218 ms [1.206 ms, 1.231 ms]	-
iast	3.189 ms [3.152 ms, 3.226 ms]	1.971 ms (161.8%)
iast_FULL	5.923 ms [5.864 ms, 5.983 ms]	4.705 ms (386.2%)
iast_GLOBAL	3.559 ms [3.5 ms, 3.618 ms]	2.341 ms (192.1%)
profiling	2.136 ms [2.117 ms, 2.155 ms]	917.537 µs (75.3%)
tracing	1.792 ms [1.778 ms, 1.806 ms]	573.702 µs (47.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	raphael/add_id_memfd
git_commit_date	1762544894	1762549451
git_commit_sha	`f132c86`	`1bd59c4`
release_version	1.56.0-SNAPSHOT~f132c86c16	1.56.0-SNAPSHOT~1bd59c4f94

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762551501	1762551501
ci_job_id	1223525128	1223525128
ci_pipeline_id	81663661	81663661
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-c3zct335 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-c3zct335 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section baseline no_agent (1.48 ms) : 1469, 1492 . : milestone, 1480, appsec (3.692 ms) : 3474, 3910 . : milestone, 3692, iast (2.212 ms) : 2148, 2275 . : milestone, 2212, iast_GLOBAL (2.254 ms) : 2190, 2318 . : milestone, 2254, profiling (2.091 ms) : 2038, 2143 . : milestone, 2091, tracing (2.04 ms) : 1990, 2089 . : milestone, 2040, section candidate no_agent (1.482 ms) : 1470, 1493 . : milestone, 1482, appsec (3.576 ms) : 3368, 3784 . : milestone, 3576, iast (2.219 ms) : 2156, 2283 . : milestone, 2219, iast_GLOBAL (2.262 ms) : 2198, 2325 . : milestone, 2262, profiling (2.083 ms) : 2030, 2136 . : milestone, 2083, tracing (2.028 ms) : 1979, 2077 . : milestone, 2028,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.469 ms, 1.492 ms]	-
appsec	3.692 ms [3.474 ms, 3.91 ms]	2.211 ms (149.4%)
iast	2.212 ms [2.148 ms, 2.275 ms]	731.204 µs (49.4%)
iast_GLOBAL	2.254 ms [2.19 ms, 2.318 ms]	773.335 µs (52.2%)
profiling	2.091 ms [2.038 ms, 2.143 ms]	610.32 µs (41.2%)
tracing	2.04 ms [1.99 ms, 2.089 ms]	559.281 µs (37.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.47 ms, 1.493 ms]	-
appsec	3.576 ms [3.368 ms, 3.784 ms]	2.094 ms (141.4%)
iast	2.219 ms [2.156 ms, 2.283 ms]	737.881 µs (49.8%)
iast_GLOBAL	2.262 ms [2.198 ms, 2.325 ms]	780.109 µs (52.7%)
profiling	2.083 ms [2.03 ms, 2.136 ms]	601.428 µs (40.6%)
tracing	2.028 ms [1.979 ms, 2.077 ms]	546.529 µs (36.9%)

Execution time for biojava

gantt title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~1bd59c4f94, baseline=1.56.0-SNAPSHOT~f132c86c16 dateFormat X axisFormat %s section baseline no_agent (15.035 s) : 15035000, 15035000 . : milestone, 15035000, appsec (14.663 s) : 14663000, 14663000 . : milestone, 14663000, iast (18.618 s) : 18618000, 18618000 . : milestone, 18618000, iast_GLOBAL (18.002 s) : 18002000, 18002000 . : milestone, 18002000, profiling (15.216 s) : 15216000, 15216000 . : milestone, 15216000, tracing (14.797 s) : 14797000, 14797000 . : milestone, 14797000, section candidate no_agent (15.391 s) : 15391000, 15391000 . : milestone, 15391000, appsec (15.376 s) : 15376000, 15376000 . : milestone, 15376000, iast (18.198 s) : 18198000, 18198000 . : milestone, 18198000, iast_GLOBAL (17.976 s) : 17976000, 17976000 . : milestone, 17976000, profiling (15.246 s) : 15246000, 15246000 . : milestone, 15246000, tracing (14.762 s) : 14762000, 14762000 . : milestone, 14762000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.035 s [15.035 s, 15.035 s]	-
appsec	14.663 s [14.663 s, 14.663 s]	-372.0 ms (-2.5%)
iast	18.618 s [18.618 s, 18.618 s]	3.583 s (23.8%)
iast_GLOBAL	18.002 s [18.002 s, 18.002 s]	2.967 s (19.7%)
profiling	15.216 s [15.216 s, 15.216 s]	181.0 ms (1.2%)
tracing	14.797 s [14.797 s, 14.797 s]	-238.0 ms (-1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.391 s [15.391 s, 15.391 s]	-
appsec	15.376 s [15.376 s, 15.376 s]	-15.0 ms (-0.1%)
iast	18.198 s [18.198 s, 18.198 s]	2.807 s (18.2%)
iast_GLOBAL	17.976 s [17.976 s, 17.976 s]	2.585 s (16.8%)
profiling	15.246 s [15.246 s, 15.246 s]	-145.0 ms (-0.9%)
tracing	14.762 s [14.762 s, 14.762 s]	-629.0 ms (-4.1%)

github-actions · 2025-11-07T01:18:36Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

amarziali · 2025-11-07T08:02:59Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

+ String arch = System.getProperty("os.arch");
+ int memfdSyscall = getMemfdSyscall(arch);
+ if (memfdSyscall <= 0) {
+ log.debug("service discovery not supported for arch={}", arch);


are you interested in sending those to the telemetry? Otherwise you won't know unless the customer activates the debug logging and send a flares. In this case you have a SEND_TELEMETRY marker

dougqh · 2025-11-07T16:19:38Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

+ private static int getMemfdSyscall(String arch) {
+ switch (arch.toLowerCase()) {
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/x86_64/bits/syscall.h.in#L320
+ case "x86_64":


You could consolidate this by allowing the case statements to fallthrough.
case "x86_64":
case "x64":
case "amd64":
return 319;

Just a suggestion, I don't feel strongly about it.

looking at these "magic numbers" makes every bone in my body shake, but because I can't think of a better idea that doesnt require a C shim 😅 or preprocessing of the source code 🫣 I'll stay quiet and say this lgtm 😜

natitsechanski

lgtm 🤷 😅

bric3 · 2025-11-10T09:56:13Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

+ case "x86_64":
+ case "x64":
+ case "amd64":
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/x86_64/bits/syscall.h.in#L320


suggestion: I would prefer the link to the linux kernel, either:

https://github.com/torvalds/linux/blob/e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c/arch/x86/entry/syscalls/syscall_64.tbl#L331

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/x86/entry/syscalls/syscall_64.tbl?h=v6.17.7#n331

bric3 · 2025-11-10T09:57:50Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/x86_64/bits/syscall.h.in#L320
+ return 319;
+ case "x386":
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/i386/bits/syscall.h.in#L356


suggestion: same as above.

https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_32.tbl#L371

Also, does makes sense to have a x86 case ?

bric3 · 2025-11-10T10:12:34Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

 final LibC libc = Native.load("c", LibC.class);

- int memFd = libc.memfd_create(fileName, MFD_CLOEXEC | MFD_ALLOW_SEALING);
+ String arch = System.getProperty("os.arch");


suggestion: Use OperatingSystem.architecture(), and the enum values in getMemfdSyscall's switch.

cc @PerfectSlayer

nice, missed that enum, will move to it later today

bric3 · 2025-11-10T10:20:27Z

...gent-tooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriter.java

+ case "aarch64":
+ case "arm64":
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/aarch64/bits/syscall.h.in#L264
+ return 279;
+ case "arm":
+ case "arm32":
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/arm/bits/syscall.h.in#L343
+ return 385;
+ case "ppc64":
+ // https://elixir.bootlin.com/musl/v1.2.5/source/arch/powerpc64/bits/syscall.h.in#L350
+ return 360;


suggestion:

arm: https://github.com/torvalds/linux/blob/e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c/arch/arm/tools/syscall.tbl#L403

arm32: https://github.com/torvalds/linux/blob/e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c/arch/arm64/tools/syscall_32.tbl#L400

aarch64 (located in a generic file) : https://github.com/torvalds/linux/blob/e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c/scripts/syscall.tbl#L329

powerpc: https://github.com/torvalds/linux/blob/e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c/arch/powerpc/kernel/syscalls/syscall.tbl#L464

move to syscall

54623c4

raphaelgavache marked this pull request as ready for review November 7, 2025 01:18

raphaelgavache requested a review from a team as a code owner November 7, 2025 01:18

raphaelgavache requested review from amarziali and natitsechanski November 7, 2025 01:18

raphaelgavache requested a review from mcculls November 7, 2025 01:18

raphaelgavache added the comp: core Tracer core label Nov 7, 2025

amarziali reviewed Nov 7, 2025

View reviewed changes

dougqh reviewed Nov 7, 2025

View reviewed changes

update after review

353ebe0

raphaelgavache added the tag: telemetry error reported Reported by error telemetry label Nov 7, 2025

natitsechanski approved these changes Nov 7, 2025

View reviewed changes

raphaelgavache added the type: enhancement Enhancements and improvements label Nov 7, 2025

Merge branch 'master' into raphael/add_id_memfd

1bd59c4

bric3 reviewed Nov 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Service discovery - remove dependency on memfd_create #9913

Service discovery - remove dependency on memfd_create #9913

Uh oh!

raphaelgavache commented Nov 6, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 6, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 7, 2025 •

edited

Loading

amarziali Nov 7, 2025

dougqh Nov 7, 2025

raphaelgavache Nov 7, 2025

natitsechanski Nov 7, 2025

natitsechanski left a comment

bric3 Nov 10, 2025

bric3 Nov 10, 2025

bric3 Nov 10, 2025

raphaelgavache Nov 10, 2025

bric3 Nov 10, 2025

Labels

6 participants

Service discovery - remove dependency on memfd_create #9913

Are you sure you want to change the base?

Service discovery - remove dependency on memfd_create #9913

Uh oh!

Conversation

raphaelgavache commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

datadog-datadog-prod-us1 bot commented Nov 6, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

pr-commenter bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natitsechanski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels

6 participants

raphaelgavache commented Nov 6, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 6, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 7, 2025 •

edited

Loading