Skip to content

Commit ffaba86

Browse files
authored
Merge pull request #392 from opaduchak/fix/ENG-8472
[ENG-8472] Files with Cyrillic in their names won't render
2 parents 8aa8251 + 46f5c3b commit ffaba86

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mfr/server/handlers/export.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import asyncio
22
import logging
33
import os
4+
from urllib.parse import quote
45

56
from waterbutler.core.exceptions import InvalidParameters, DownloadError
67
import waterbutler.core.streams
@@ -118,6 +119,6 @@ async def _cache_and_clean(self):
118119
pass
119120

120121
def _set_headers(self):
121-
self.set_header('Content-Disposition', 'attachment;filename="{}"'.format('{}.{}'.format(self.metadata.name.replace('"', '\\"'), self.format)))
122+
self.set_header('Content-Disposition', f'attachment;filename*=UTF-8\'\'{quote(self.metadata.name.replace('"', '\\"'))}.{self.format}')
122123
if self.metadata.content_type:
123124
self.set_header('Content-Type', self.metadata.content_type)

0 commit comments

Comments
 (0)