Skip to content

Commit dbc62b1

Browse files
committed
fix helper button issue
1 parent 87c122e commit dbc62b1

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

lib/osf-components/addon/components/addons-service/configured-addon-edit/styles.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,7 @@
6868
white-space: pre-wrap;
6969

7070
}
71+
72+
.trigger {
73+
width: 130px;
74+
}

lib/osf-components/addon/components/addons-service/configured-addon-edit/template.hbs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -167,25 +167,29 @@
167167
></GoogleFilePickerWidget>
168168
{{/if}}
169169
{{#if this.isLinkAddon}}
170-
<label>
171-
{{t 'addons.configure.resource-type'}}
172-
<Button
173-
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
174-
@layout='fake-link'
175-
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
176-
>
177-
<FaIcon @icon='question-circle' />
178-
</Button>
170+
{{#let (unique-id 'resource-type') as |resourceTypeId|}}
171+
<label for={{resourceTypeId}}>
172+
{{t 'addons.configure.resource-type'}}
173+
<Button
174+
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
175+
@layout='fake-link'
176+
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
177+
>
178+
<FaIcon @icon='question-circle' />
179+
</Button>
180+
</label>
179181
<PowerSelect
182+
id={{resourceTypeId}}
180183
@options={{@supportedResourceTypes}}
181184
@selected={{this.selectedResourceType}}
182185
@onChange={{action (mut this.selectedResourceType)}}
186+
@triggerClass={{local-class 'trigger'}}
183187
@placeholder={{t 'addons.configure.resource-type-placeholder'}}
184188
as |resourceType|
185189
>
186190
{{resourceType}}
187191
</PowerSelect>
188-
</label>
192+
{{/let}}
189193
{{/if}}
190194
<div local-class='footer-buttons-wrapper'>
191195
<Button

0 commit comments

Comments
 (0)