Skip to content

Commit 233ec4f

Browse files
committed
Merge tag '25.13.2' into develop
Hotfix resource helper button
2 parents 302e8e1 + b21d2b5 commit 233ec4f

File tree

4 files changed

+21
-12
lines changed

4 files changed

+21
-12
lines changed

app/guid-node/links/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
{{else}}
4242
<p>{{t 'links.empty-screen-message'}}</p>
4343
{{#if this.currentUserCanEdit}}
44-
<p> {{t 'links.point-to-addons-message'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a></p>
44+
<p> {{t 'links.point-to-addons-message-1'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a>{{t 'links.point-to-addons-message-2'}}</p>
4545
{{/if}}
4646
{{/if}}
4747
</div>

lib/osf-components/addon/components/addons-service/configured-addon-edit/styles.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,7 @@
6868
white-space: pre-wrap;
6969

7070
}
71+
72+
.trigger {
73+
width: 130px;
74+
}

lib/osf-components/addon/components/addons-service/configured-addon-edit/template.hbs

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -167,25 +167,29 @@
167167
></GoogleFilePickerWidget>
168168
{{/if}}
169169
{{#if this.isLinkAddon}}
170-
<label>
171-
{{t 'addons.configure.resource-type'}}
172-
<Button
173-
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
174-
@layout='fake-link'
175-
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
176-
>
177-
<FaIcon @icon='question-circle' />
178-
</Button>
170+
{{#let (unique-id 'resource-type') as |resourceTypeId|}}
171+
<label for={{resourceTypeId}}>
172+
{{t 'addons.configure.resource-type'}}
173+
<Button
174+
aria-label={{t 'addons.configure.resource-type-helper-aria-label'}}
175+
@layout='fake-link'
176+
{{on 'click' (fn (mut this.isResourceTypeDialogOpen) true)}}
177+
>
178+
<FaIcon @icon='question-circle' />
179+
</Button>
180+
</label>
179181
<PowerSelect
182+
id={{resourceTypeId}}
180183
@options={{@supportedResourceTypes}}
181184
@selected={{this.selectedResourceType}}
182185
@onChange={{action (mut this.selectedResourceType)}}
186+
@triggerClass={{local-class 'trigger'}}
183187
@placeholder={{t 'addons.configure.resource-type-placeholder'}}
184188
as |resourceType|
185189
>
186190
{{resourceType}}
187191
</PowerSelect>
188-
</label>
192+
{{/let}}
189193
{{/if}}
190194
<div local-class='footer-buttons-wrapper'>
191195
<Button

translations/en-us.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,8 @@ links:
400400
display-name: 'Display Name'
401401
resource-type: 'Resource Type'
402402
empty-screen-message: 'This project has no configured linked services at the moment '
403-
point-to-addons-message: 'In order to add linked service visit'
403+
point-to-addons-message-1: 'Visit '
404+
point-to-addons-message-2: ' to add a linked service.'
404405
link: 'Link'
405406
edit: 'Edit'
406407
icon: '{addonName} icon'

0 commit comments

Comments
 (0)