refactor: use object destructuring for require statements

Author: macklinu

.eslintrc.js

@@ -1,11 +1,12 @@
 'use strict';
 
-const globals = require('./index').environments.globals.globals;
+const { globals } = require('./index').environments.globals;
 
 module.exports = {
  extends: [
  'eslint:recommended',
  'plugin:eslint-plugin/recommended',
+ 'plugin:node/recommended',
  'prettier',
  ],
  plugins: ['eslint-plugin', 'node', 'prettier'],
@@ -22,6 +23,15 @@ module.exports = {
  'prefer-template': 'warn',
  'object-shorthand': ['warn', 'always', { avoidExplicitReturnArrows: true }],
  'node/no-unsupported-features': 'error',
+ 'prefer-destructuring': [
+ 'error',
+ {
+ VariableDeclarator: {
+ array: true,
+ object: true,
+ },
+ },
+ ],
  'prettier/prettier': 'error',
  },
  overrides: [

__tests__/rules.test.js

@@ -2,7 +2,7 @@
 
 const fs = require('fs');
 const path = require('path');
-const rules = require('../index').rules;
+const { rules } = require('../index');
 
 describe('rules', () => {
  it('should have a corresponding doc for each rule', () => {

processors/__tests__/snapshot-processor.test.js

@@ -12,7 +12,7 @@ describe('snapshot-processor', () => {
 
  describe('preprocess function', () => {
  it('should pass on untouched source code to source array', () => {
- const preprocess = snapshotProcessor.preprocess;
+ const { preprocess } = snapshotProcessor;
  const sourceCode = "const name = 'johnny bravo';";
  const result = preprocess(sourceCode);
 
@@ -22,7 +22,7 @@ describe('snapshot-processor', () => {
 
  describe('postprocess function', () => {
  it('should only return messages about snapshot specific rules', () => {
- const postprocess = snapshotProcessor.postprocess;
+ const { postprocess } = snapshotProcessor;
  const result = postprocess([
  [
  { ruleId: 'no-console' },

rules/__tests__/consistent-test-it.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../consistent-test-it');
 
 const ruleTester = new RuleTester({

rules/__tests__/expect-expect.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../expect-expect');
 
 const ruleTester = new RuleTester({

rules/__tests__/lowercase-name.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../lowercase-name');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-alias-methods.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-alias-methods');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-disabled-tests.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-disabled-tests');
 
 const ruleTester = new RuleTester({

rules/__tests__/no-focused-tests.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-focused-tests');
 
 const ruleTester = new RuleTester();

rules/__tests__/no-hooks.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const RuleTester = require('eslint').RuleTester;
+const { RuleTester } = require('eslint');
 const rule = require('../no-hooks');
 
 const ruleTester = new RuleTester({