Skip to content

fix: show warning when hot is enabled with the HMR plugin in config #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2021
Merged

fix: show warning when hot is enabled with the HMR plugin in config #3744

merged 2 commits into from
Aug 25, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP on tests.

Motivation / Use-Case

show users a warning when hot is enabled with the HMR plugin in the configuration

Breaking Changes

None

Additional Info

No
@snitin315 snitin315 marked this pull request as draft August 25, 2021 12:02
alexander-akait
alexander-akait previously approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add test, looks fine
@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #3744 (03a9189) into master (8f20c3e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3744 +/- ## ======================================= Coverage 92.89% 92.90% ======================================= Files 14 14 Lines 1323 1324 +1 Branches 466 465 -1 ======================================= + Hits 1229 1230 +1  Misses 87 87 Partials 7 7
Impacted Files Coverage Δ
lib/Server.js 93.86% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f20c3e...03a9189. Read the comment docs.
@snitin315 snitin315 marked this pull request as ready for review August 25, 2021 13:19
@snitin315 snitin315 merged commit 6cb1e4e into master Aug 25, 2021
@snitin315 snitin315 deleted the hmr-warning branch August 25, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@snitin315 @alexander-akait @anshumanv