Merge pull request #186 from webpack-contrib/fix/sources-content-missing

fix: sourcesContent missing in source maps

Author: jhnns

src/getOptions.js

@@ -24,6 +24,16 @@ function getOptions(loaderContext) {
  options.plugins.push(createWebpackLessPlugin(loaderContext));
  }
 
+ if (options.sourceMap) {
+ if (typeof options.sourceMap === 'boolean') {
+ options.sourceMap = {};
+ }
+ if ('outputSourceFiles' in options.sourceMap === false) {
+ // Include source files as `sourceContents` as sane default since this makes source maps "just work" in most cases
+ options.sourceMap.outputSourceFiles = true;
+ }
+ }
+
  return options;
 }
 

test/helpers/createSpec.js

@@ -28,6 +28,7 @@ const lessOptions = {
  '--source-map',
  `--source-map-basepath=${projectPath}`,
  `--source-map-rootpath=${projectPath}`,
+ '--source-map-less-inline',
  ],
  'import-paths': [
  `--include-path=${path.resolve(fixturesPath, 'node_modules')}`,

test/index.test.js

@@ -165,7 +165,7 @@ test('should transform urls', async () => {
  await compileAndCompare('url-path');
 });
 
-test('should generate source maps', async () => {
+test('should generate source maps with sourcesContent by default', async () => {
  let inspect;
  const rules = moduleRules.basic({ sourceMap: true }, {}, (i) => {
  inspect = i;
@@ -177,10 +177,30 @@ test('should generate source maps', async () => {
  ]);
  const [actualCss, actualMap] = inspect.arguments;
 
+ expect(Array.isArray(actualMap.sourcesContent)).toBe(true);
+ expect(actualMap.sourcesContent.length).toBe(2);
+
+ // We can't actually compare the sourcesContent because it's slightly different because of our import rewriting
+ delete actualMap.sourcesContent;
+ delete expectedMap.sourcesContent;
+
  expect(actualCss).toEqual(expectedCss);
  expect(actualMap).toEqual(expectedMap);
 });
 
+test('should be possible to override sourceMap.outputSourceFiles', async () => {
+ let inspect;
+ const rules = moduleRules.basic({ sourceMap: { outputSourceFiles: false } }, {}, (i) => {
+ inspect = i;
+ });
+
+ await compile('source-map', rules);
+
+ const [actualMap] = inspect.arguments;
+
+ expect(actualMap).not.toHaveProperty('sourcesContent');
+});
+
 test('should install plugins', async () => {
  let pluginInstalled = false;
  // Using prototype inheritance here since Less plugins are usually instances of classes