Skip to content

Conversation

nieyuyao
Copy link
Contributor

@nieyuyao nieyuyao commented Aug 4, 2024

fix #11326.

we should ensure the rendering result of slot is valid in ssr. keep it consistent with runtime.

@nieyuyao nieyuyao force-pushed the fix/ssrRenderSlot branch from e9942d0 to ddf1a30 Compare August 6, 2024 09:12
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit e9942d0
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66b1e8c0400a0e0008cb25d3
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 7eb3b6a
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66b1f9b305e38c0008903a9e
@nieyuyao nieyuyao force-pushed the fix/ssrRenderSlot branch from ddf1a30 to 7eb3b6a Compare August 6, 2024 10:23
Copy link

github-actions bot commented Aug 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB 34.6 kB (+1 B) 31.1 kB (+14 B)
vue.global.prod.js 147 kB 54 kB 48 kB (-21 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB (+1 B) 17.8 kB (-3 B)
createSSRApp 53.2 kB 21 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB (-4 B)
overall 63.1 kB 24.5 kB (+1 B) 22.3 kB (-35 B)
@edison1105 edison1105 changed the title fix(ssrRenderSlot): ensure content is valid when rendering slot fix(ssr): ensure content is valid when rendering normal slot Aug 7, 2024
@edison1105 edison1105 added scope: slots scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 7, 2024
@yyx990803 yyx990803 merged commit 6c90324 into vuejs:main Aug 7, 2024
@nieyuyao nieyuyao deleted the fix/ssrRenderSlot branch September 2, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: slots scope: ssr

3 participants