fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set

[tetsuharuohzeki]

PR Checklist

• Addresses an existing open issue: fixes Bug: [class-methods-use-this] Cannot detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface option is true #7704
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This fixes #7704.

TypeScript's interface feature does not have any private/protected member as a part of it.

So the rule class-methods-use-this enabling ignoreClassesThatImplementAnInterface=true should warn the case of that the implementation is not a part of interface.

[typescript-eslint]

Thanks for the PR, @tetsuharuohzeki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	be7c886
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6557ebe495ba9600084d121a
😎 Deploy Preview	https://deploy-preview-7705--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 8 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3625d70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 19 targets

• nx test eslint-plugin --coverage=false
• nx test type-utils --coverage=false
• nx run types:build
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run repo-tools:postinstall-script
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx test repo-tools --coverage=false
• nx test ast-spec --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx test scope-manager --coverage=false
• nx run-many --target=lint --parallel
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

Converting to draft since the linked issue hasn't been accepted yet. Let's continue conversation there.

[JoshuaKGoldberg]

OK! This looks great to me - just one docs suggestion from me. What do you think @tetsuharuohzeki?

Thanks for waiting btw - I'm excited about this option!

[JoshuaKGoldberg]

Hmm, this looks a little off... outside the scope of this PR.

[tetsuharuohzeki]

I tried to remove its comment but I seem nx run eslint-plugin:test generate it...

[tetsuharuohzeki]

I tried to add more descriptions but it cannot remove extra comments.
7390468

[JoshuaKGoldberg]

Yeah I think this is just something odd in the repository, separate from your changes. No worries. Thanks for trying though!

[JoshuaKGoldberg]

Swell, thanks!

[JoshuaKGoldberg]

I introduced a merge conflict on main and can fix it :)

[tetsuharuohzeki]

@JoshuaKGoldberg

Thank you for your review! I rebase my change sets on the latest main!

[JoshuaKGoldberg]

Amazing, thanks! Saved me a bit of time wrestling with it locally. 🙂

[tetsuharuohzeki]

@JoshuaKGoldberg Thank you for accepting my patch.