Relaxing element type definitions to HTMLElement #649
Conversation
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c60735d:
|
src/__tests__/upload.js Outdated
| expect(Array.from(eventTargetFiles)).toEqual(files) | ||
| }) | ||
| | ||
| test('should give error if we are trying to call upload on an invalid element', () => { |
There was a problem hiding this comment.
This is pretty much just a copy / paste from the existing test in paste.js.
Codecov Report
@@ Coverage Diff @@ ## master #649 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 50 50 Lines 922 930 +8 Branches 363 366 +3 ========================================= + Hits 922 930 +8
Continue to review full report at Codecov.
|
ph-fritsche left a comment
ph-fritsche left a comment There was a problem hiding this comment.
Thanks for taking the time to contribute. ❤️
ph-fritsche left a comment
ph-fritsche left a comment There was a problem hiding this comment.
I've opened a PR with code suggestions at GreenGremlin#1
fix: guard against unsupported elements
| @ph-fritsche thanks! I've merged your changes. |
| @all-contributors add @GreenGremlin code |
| I've put up a pull request to add @GreenGremlin! 🎉 |
| 🎉 This PR is included in version 13.1.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
| Thank you! |
2 participants
Fixes #648
What: Relaxing element argument types to match the type returned by react-testing-library queries.
Why:
To allow user-event functions to be used with RTS queries without type casting.
How:
I'm narrowing the element type by checking that the passed elements are instances of valid element types. Thus, the check is runtime only, which makes sense since DOM queries are not fully type safe.
Checklist: